trunk Ejb3Deployment is incompatible with jbossas trunk

[starksm64]

The ejb3 trunk Ejb3Deployment is incompatible with the current usage due to a change in the ctor. The jbossas Ejb3JBoss5Deployment is calling a non-existent ctor:

Caused by: java.lang.NoSuchMethodError: org.jboss.ejb3.Ejb3Deployment.<init>(Lorg/jboss/ejb3/DeploymentUnit;Lorg/jboss/ejb3/DeploymentScope;Lorg/jboss/metadata/ejb/jboss/JBossMetaData;Lorg/jboss/ejb3/metadata/jpa/spec/PersistenceUnitsMetaData;)V
 at org.jboss.ejb3.deployers.Ejb3JBoss5Deployment.<init>(Ejb3JBoss5Deployment.java:62)
 at org.jboss.ejb3.deployers.Ejb3Deployer.deploy(Ejb3Deployer.java:165)
 ... 21 more

I guess its the move to have the PersistenceUnitsMetaData be part of jboss-metadata. When is the next ejb3 release?

[alrubinger]

I've fixed this locally in preparation for the next release and integration, but have not yet been able to test.

Throw a watch on here to be notified:

http://jira.jboss.com/jira/browse/EJBTHREE-1390

S,
ALR

[alesj]

I guess its the move to have the PersistenceUnitsMetaData be part of jboss-metadata. When is the next ejb3 release?

Yup, this is a result of:
- http://www.jboss.com/index.html?module=bb&op=viewtopic&t=136246
I'll fix the URL handling today - probably in next few hours (already got the code, just need to test it and do VFS release).

[alesj]

This is the 'svn diff' that I have locally:

Index: ejb3/src/main/org/jboss/ejb3/deployers/Ejb3JBoss5Deployment.java
===================================================================
--- ejb3/src/main/org/jboss/ejb3/deployers/Ejb3JBoss5Deployment.java (revision 74099)
+++ ejb3/src/main/org/jboss/ejb3/deployers/Ejb3JBoss5Deployment.java (working copy)
@@ -22,27 +22,29 @@
 package org.jboss.ejb3.deployers;

 import java.util.Map;
-
 import javax.management.MBeanServer;
 import javax.management.ObjectName;
-import javax.management.MalformedObjectNameException;
 import javax.security.jacc.PolicyConfiguration;

 import org.jboss.beans.metadata.plugins.AbstractSupplyMetaData;
 import org.jboss.deployment.MappedReferenceMetaDataResolverDeployer;
 import org.jboss.deployment.dependency.ContainerDependencyMetaData;
-import org.jboss.ejb3.*;
+import org.jboss.ejb3.Container;
+import org.jboss.ejb3.DependencyPolicy;
+import org.jboss.ejb3.DeploymentScope;
+import org.jboss.ejb3.DeploymentUnit;
+import org.jboss.ejb3.EJBContainer;
+import org.jboss.ejb3.Ejb3Deployment;
+import org.jboss.ejb3.MCDependencyPolicy;
 import org.jboss.ejb3.javaee.JavaEEComponent;
-import org.jboss.ejb3.javaee.JavaEEModule;
-import org.jboss.ejb3.javaee.JavaEEApplication;
 import org.jboss.ejb3.kernel.JNDIKernelRegistryPlugin;
-import org.jboss.ejb3.metadata.jpa.spec.PersistenceUnitsMetaData;
 import org.jboss.kernel.Kernel;
 import org.jboss.logging.Logger;
 import org.jboss.metadata.ejb.jboss.JBossEnterpriseBeanMetaData;
 import org.jboss.metadata.ejb.jboss.JBossMetaData;
 import org.jboss.metadata.ejb.jboss.JBossSessionBeanMetaData;
 import org.jboss.metadata.ejb.jboss.jndipolicy.spi.EjbDeploymentSummary;
+import org.jboss.metadata.jpa.spec.PersistenceMetaData;

 /**
 * JBoss 5.0 Microkernel specific implementation
@@ -57,7 +59,7 @@
 private org.jboss.deployers.structure.spi.DeploymentUnit jbossUnit;
 private Map<String, ContainerDependencyMetaData> endpoints;

- public Ejb3JBoss5Deployment(DeploymentUnit ejb3Unit, Kernel kernel, MBeanServer mbeanServer, org.jboss.deployers.structure.spi.DeploymentUnit jbossUnit, DeploymentScope deploymentScope, JBossMetaData metaData, PersistenceUnitsMetaData persistenceUnitsMetaData)
+ public Ejb3JBoss5Deployment(DeploymentUnit ejb3Unit, Kernel kernel, MBeanServer mbeanServer, org.jboss.deployers.structure.spi.DeploymentUnit jbossUnit, DeploymentScope deploymentScope, JBossMetaData metaData, PersistenceMetaData persistenceUnitsMetaData)
 {
 super(ejb3Unit, deploymentScope, metaData, persistenceUnitsMetaData);
 this.jbossUnit = jbossUnit;
Index: ejb3/src/main/org/jboss/ejb3/deployers/PersistenceUnitParsingDeployer.java
===================================================================
--- ejb3/src/main/org/jboss/ejb3/deployers/PersistenceUnitParsingDeployer.java (revision 74099)
+++ ejb3/src/main/org/jboss/ejb3/deployers/PersistenceUnitParsingDeployer.java (working copy)
@@ -21,21 +21,9 @@
 */
 package org.jboss.ejb3.deployers;

-import java.net.URL;
-import java.util.HashMap;
+import org.jboss.deployers.vfs.spi.deployer.SchemaResolverDeployer;
+import org.jboss.metadata.jpa.spec.PersistenceMetaData;

-import javax.persistence.spi.PersistenceUnitTransactionType;
-
-import org.hibernate.cfg.EJB3DTDEntityResolver;
-import org.hibernate.ejb.packaging.PersistenceXmlLoader;
-import org.jboss.deployers.structure.spi.DeploymentUnit;
-import org.jboss.deployers.vfs.spi.deployer.AbstractVFSParsingDeployer;
-import org.jboss.deployers.vfs.spi.structure.VFSDeploymentUnit;
-import org.jboss.ejb3.metadata.jpa.spec.PersistenceUnitsMetaData;
-import org.jboss.ejb3.protocol.jarjar.Handler;
-import org.jboss.logging.Logger;
-import org.jboss.virtual.VirtualFile;
-
 /**
 * Find and parse persistence.xml.
 *
@@ -46,74 +34,15 @@
 * WEB-INF/classes/META-INF/persistence.xml
 *
 * @author <a href="mailto:[e-mail]">Carlo de Wolf</a>
+ * @author <a href="mailto:[e-mail]">Ales Justin</a>
 * @version $Revision$
 */
-public class PersistenceUnitParsingDeployer extends AbstractVFSParsingDeployer<PersistenceUnitsMetaData>
+public class PersistenceUnitParsingDeployer extends SchemaResolverDeployer<PersistenceMetaData>
 {
- private static final Logger log = Logger.getLogger(PersistenceUnitParsingDeployer.class);
-
- static
- {
- Handler.init();
- }
-
 public PersistenceUnitParsingDeployer()
 {
- super(PersistenceUnitsMetaData.class);
+ super(PersistenceMetaData.class);
 setName("persistence.xml");
+ setRegisterWithJBossXB(true);
 }
-
- @Override
- protected PersistenceUnitsMetaData parse(DeploymentUnit unit, String name, PersistenceUnitsMetaData root) throws Exception
- {
- // Try to find the metadata
- VFSDeploymentUnit vfsDeploymentUnit = (VFSDeploymentUnit) unit;
-
- VirtualFile file = vfsDeploymentUnit.getMetaDataFile(name);
- if (file == null)
- {
- // FIXME: hack to get a war persistence unit
- try
- {
- file = vfsDeploymentUnit.getFile("WEB-INF/classes/META-INF/persistence.xml");
- if(file == null)
- return null;
- }
- catch(IllegalStateException e)
- {
- return null;
- }
- // -- //
- }
-
- PersistenceUnitsMetaData result = parse(vfsDeploymentUnit, file, root);
- if (result != null)
- init(vfsDeploymentUnit, result, file);
- return result;
- }
-
- @Override
- protected PersistenceUnitsMetaData parse(VFSDeploymentUnit unit, VirtualFile file, PersistenceUnitsMetaData root)
- throws Exception
- {
- VirtualFile persistenceRoot = file.getParent().getParent();
-
- // We can't pass in a VFS url.
- //URL persistenceUnitRootUrl = persistenceRoot.toURL();
-
- // FIXME: is this a supported hack?
- // This introduces severe regression, will go the jar: url way (EJB-326)
- //URL persistenceUnitRootUrl = new URL("jarjar:" + persistenceRoot.getHandler().toURL());
-
- // http://opensource.atlassian.com/projects/hibernate/browse/EJB-326
- URL persistenceUnitRootUrl = persistenceRoot.toURL();
- assert persistenceUnitRootUrl.getProtocol().equals("jar") || persistenceUnitRootUrl.getProtocol().equals("file") : "expected a jar or file url, but was " + persistenceUnitRootUrl;
-
- URL persistenceXmlUrl = file.toURL();
- PersistenceUnitsMetaData metaData = new PersistenceUnitsMetaData(persistenceUnitRootUrl, PersistenceXmlLoader.deploy(persistenceXmlUrl, new HashMap<String, String>(),
- new EJB3DTDEntityResolver(), PersistenceUnitTransactionType.JTA));
- log.info("Found persistence units " + metaData);
- // FIXME: if in EAR then unscoped else scoped
- return metaData;
- }
 }
Index: ejb3/src/main/org/jboss/ejb3/deployers/Ejb3Deployer.java
===================================================================
--- ejb3/src/main/org/jboss/ejb3/deployers/Ejb3Deployer.java (revision 74099)
+++ ejb3/src/main/org/jboss/ejb3/deployers/Ejb3Deployer.java (working copy)
@@ -23,7 +23,6 @@

 import java.util.Properties;
 import java.util.Set;
-
 import javax.management.MBeanServer;

 import org.jboss.deployers.spi.DeploymentException;
@@ -41,8 +40,8 @@
 import org.jboss.ejb3.proxy.factory.RemoteProxyFactoryRegistry;
 import org.jboss.kernel.Kernel;
 import org.jboss.kernel.spi.deployment.KernelDeployment;
-import org.jboss.metadata.ear.jboss.JBossAppMetaData;
 import org.jboss.metadata.ejb.jboss.JBossMetaData;
+import org.jboss.metadata.jpa.spec.PersistenceMetaData;
 import org.jboss.metadata.web.jboss.JBossWebMetaData;
 import org.jboss.virtual.VirtualFile;

@@ -92,10 +91,10 @@
 @Override
 public void deploy(VFSDeploymentUnit unit) throws DeploymentException
 {
- deploy(unit, unit.getAttachment(JBossMetaData.class), unit.getAttachment(PersistenceUnitsMetaData.class));
+ deploy(unit, unit.getAttachment(JBossMetaData.class), unit.getAttachment(PersistenceMetaData.class));
 }

- public void deploy(VFSDeploymentUnit unit, JBossMetaData metaData, PersistenceUnitsMetaData persistenceUnitsMetaData) throws DeploymentException
+ public void deploy(VFSDeploymentUnit unit, JBossMetaData metaData, PersistenceMetaData persistenceUnitsMetaData) throws DeploymentException
 {
 try
 {

Which fixes this.

btw: I've commited the change + released VFS 2.0.0.Beta13.

[alesj]

"alesj" wrote:

btw: I've commited the change + released VFS 2.0.0.Beta13.

The change to EJB3 code, the way we handle URL of unit holding persistence.xml. :-)

[alrubinger]

I've released EJB3 Core 0.1.2.

So now we've got a chicken/egg thing. I couldn't test this against AS because of the API conflict, and Ales couldn't resolve the API conflict until I released. :)

Both Anil and I tried Ales' patch in this Thread to resolve AS to no avail.

Ales, how'd you like to proceed? You can upgrade AS locally, check your patch by running the new AS TestSuite Smoke tests, and if that's good, push the upgrade on your own. Alternatively you can send me another patch to the "ejb3" module and I'll do testing and make the final commits.

Other projects waiting on this, so this is a bit of a priority.

After this is resolved, I'll recommit my changes to introduce EJB3 Proxy into EJB3 Core, and do a follow-up release.

S,
ALR

[starksm64]

I'll look at getting the ejb3 module working with 0.1.2.

[starksm64]

I have it compiling, and starting, but runtime is showing vfs version issues:

16:39:12,728 ERROR [AbstractKernelController] Error installing to Start: name=persistence.units:ear=ejb3_pm_basic_vehicles.ear,unitName=CTS-EM state=Create
java.lang.NoSuchMethodError: org.jboss.virtual.VFSUtils.isNestedFile(Lorg/jboss/virtual/VirtualFile;)Z
 at org.jboss.ejb3.entity.PersistenceUnitDeployment.start(PersistenceUnitDeployment.java:227)

What vfs version is needed?

[alrubinger]

VFS Beta13 was released the 3rd of June...:

http://repository.jboss.org/maven2/org/jboss/jboss-vfs/2.0.0.Beta13/

EJB3 Core has no dependency on this. Try upgrading from 11 to 13?

S,
ALR

[starksm64]

On trying vfs 2.0.0.Beta13 there are parse errors:

16:52:56,502 ERROR [AbstractKernelController] Error installing to Parse: name=vfszip:/Users/svn/JBossHead/jboss-head/build/output/jboss-5.0.0.CR1/server/cts/tmp/jsr88/ejb3_pm_basic_vehicles.ear state=Not Installed mode=Manual requiredState=Parse
org.jboss.deployers.spi.DeploymentException: Error creating managed object for vfszip:/Users/svn/JBossHead/jboss-head/build/output/jboss-5.0.0.CR1/server/cts/tmp/jsr88/ejb3_pm_basic_vehicles.ear/ejb3_pm_basic_appmanagedNoTx_vehicle_client.jar
 at org.jboss.deployers.spi.DeploymentException.rethrowAsDeploymentException(DeploymentException.java:49)
 at org.jboss.deployers.spi.deployer.helpers.AbstractParsingDeployerWithOutput.createMetaData(AbstractParsingDeployerWithOutput.java:337)
 at org.jboss.deployers.spi.deployer.helpers.AbstractParsingDeployerWithOutput.createMetaData(AbstractParsingDeployerWithOutput.java:297)
 at org.jboss.deployers.spi.deployer.helpers.AbstractParsingDeployerWithOutput.createMetaData(AbstractParsingDeployerWithOutput.java:269)
 at org.jboss.deployers.spi.deployer.helpers.AbstractParsingDeployerWithOutput.deploy(AbstractParsingDeployerWithOutput.java:230)
 at org.jboss.deployers.plugins.deployers.DeployerWrapper.deploy(DeployerWrapper.java:174)
 at org.jboss.deployers.plugins.deployers.DeployersImpl.doInstallParentFirst(DeployersImpl.java:970)
 at org.jboss.deployers.plugins.deployers.DeployersImpl.doInstallParentFirst(DeployersImpl.java:1023)
 at org.jboss.deployers.plugins.deployers.DeployersImpl.install(DeployersImpl.java:911)
 at org.jboss.dependency.plugins.AbstractControllerContext.install(AbstractControllerContext.java:348)
 at org.jboss.dependency.plugins.AbstractController.install(AbstractController.java:1394)
 at org.jboss.dependency.plugins.AbstractController.incrementState(AbstractController.java:786)
 at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:914)
 at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:836)
 at org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:674)
 at org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:456)
 at org.jboss.deployers.plugins.deployers.DeployersImpl.process(DeployersImpl.java:594)
 at org.jboss.deployers.plugins.main.MainDeployerImpl.process(MainDeployerImpl.java:541)
 at org.jboss.deployment.services.DeploymentManagerService.deploy_phase2(DeploymentManagerService.java:412)
 at org.jboss.deployment.services.DeploymentManagerService.deploy(DeploymentManagerService.java:295)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:585)
 at org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:157)
 at org.jboss.mx.server.Invocation.dispatch(Invocation.java:96)
 at org.jboss.mx.server.Invocation.invoke(Invocation.java:88)
 at org.jboss.mx.server.AbstractMBeanInvoker.invoke(AbstractMBeanInvoker.java:264)
 at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:668)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:585)
 at org.jboss.jmx.connector.invoker.InvokerAdaptorService.invoke(InvokerAdaptorService.java:270)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:585)
 at org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:157)
 at org.jboss.mx.server.Invocation.dispatch(Invocation.java:96)
 at org.jboss.mx.interceptor.AbstractInterceptor.invoke(AbstractInterceptor.java:138)
 at org.jboss.mx.server.Invocation.invoke(Invocation.java:90)
 at org.jboss.mx.interceptor.ModelMBeanOperationInterceptor.invoke(ModelMBeanOperationInterceptor.java:140)
 at org.jboss.jmx.connector.invoker.SerializableInterceptor.invoke(SerializableInterceptor.java:74)
 at org.jboss.mx.server.Invocation.invoke(Invocation.java:90)
 at org.jboss.mx.server.AbstractMBeanInvoker.invoke(AbstractMBeanInvoker.java:264)
 at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:668)
 at org.jboss.invocation.jrmp.server.JRMPProxyFactory.invoke(JRMPProxyFactory.java:179)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:585)
 at org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:157)
 at org.jboss.mx.server.Invocation.dispatch(Invocation.java:96)
 at org.jboss.mx.server.Invocation.invoke(Invocation.java:88)
 at org.jboss.mx.server.AbstractMBeanInvoker.invoke(AbstractMBeanInvoker.java:264)
 at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:668)
 at org.jboss.invocation.jrmp.server.JRMPInvoker$MBeanServerAction.invoke(JRMPInvoker.java:815)
 at org.jboss.invocation.jrmp.server.JRMPInvoker.invoke(JRMPInvoker.java:416)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:585)
 at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:294)
 at sun.rmi.transport.Transport$1.run(Transport.java:153)
 at java.security.AccessController.doPrivileged(Native Method)
 at sun.rmi.transport.Transport.serviceCall(Transport.java:149)
 at sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:466)
 at sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:707)
 at java.lang.Thread.run(Thread.java:613)
Caused by: org.jboss.xb.binding.JBossXBException: Failed to parse source: Premature end of file. @ *unknown*[-1,-1]
 at org.jboss.xb.binding.parser.sax.SaxJBossXBParser.parse(SaxJBossXBParser.java:193)
 at org.jboss.xb.binding.UnmarshallerImpl.unmarshal(UnmarshallerImpl.java:153)
 at org.jboss.deployers.vfs.spi.deployer.SchemaResolverDeployer.parse(SchemaResolverDeployer.java:214)
 at org.jboss.deployers.vfs.spi.deployer.SchemaResolverDeployer.parse(SchemaResolverDeployer.java:198)
 at org.jboss.deployers.vfs.spi.deployer.AbstractVFSParsingDeployer.parse(AbstractVFSParsingDeployer.java:127)
 at org.jboss.deployers.spi.deployer.helpers.AbstractParsingDeployerWithOutput.createMetaData(AbstractParsingDeployerWithOutput.java:323)
 ... 68 more
Caused by: org.xml.sax.SAXException: Premature end of file. @ *unknown*[-1,-1]
 at org.jboss.xb.binding.parser.sax.SaxJBossXBParser$MetaDataErrorHandler.fatalError(SaxJBossXBParser.java:438)
 at org.apache.xerces.util.ErrorHandlerWrapper.fatalError(Unknown Source)
 at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source)
 at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source)
 at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source)
 at org.apache.xerces.impl.XMLVersionDetector.determineDocVersion(Unknown Source)
 at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
 at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
 at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
 at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
 at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
 at org.jboss.xb.binding.parser.sax.SaxJBossXBParser.parse(SaxJBossXBParser.java:189)
 ... 73 more

[alrubinger]

Anil tried a manual upgrade, and also reported running into JBossXB parsing errors. Will ping him to see if these are the same.

S,
ALR

[starksm64]

The PersistenceUnitParsingDeployer has been moved into the jbossas/ejb3 module as JBoss5PersistenceUnitParsingDeployer:

package org.jboss.ejb3.deployers;

import org.jboss.deployers.vfs.spi.deployer.SchemaResolverDeployer;
import org.jboss.metadata.jpa.spec.PersistenceMetaData;

/**
 * Find and parse persistence.xml.
 *
 * In a jar:
 * META-INF/persistence.xml
 *
 * In a war (JPA 6.2):
 * WEB-INF/classes/META-INF/persistence.xml
 *
 * @author <a href="mailto:[e-mail]">Carlo de Wolf</a>
 * @author <a href="mailto:[e-mail]">Ales Justin</a>
 * @version $Revision: 72433 $
 */
public class JBoss5PersistenceUnitParsingDeployer extends SchemaResolverDeployer<PersistenceMetaData>
{
 public JBoss5PersistenceUnitParsingDeployer()
 {
 super(PersistenceMetaData.class);
 setName("persistence.xml");
 setRegisterWithJBossXB(true);
 }

}

[anil.saldhana]

Yeah, XB error was when I gave up the endeavour and moved onto fixing aspects security.

[wolfc]

The constructor should be reinstated. It's not allowed to throw backwards compatibility out the door just like that.

The old constructor should use some transitional code to call upon the new constructor (preferably with some deprecation warnings).

[starksm64]

Its really not usable though as unless something is producing the new org.jboss.metadata.jpa.spec.PersistenceMetaData from the old org.jboss.ejb3.metadata.jpa.spec.PersistenceUnitsMetaData, persistence units will not be processed correctly.

Restoration of the PersistenceUnitsMetaData based ctor also requires a wrapper to map from the PersistenceUnitsMetaData to the new PersistenceMetaData.