Filtering non-EJB3 deployments in the EJB3 deployer

[aloubyansky]

Currently it's done like this

public void deploy(VFSDeploymentUnit unit, JBossMetaData metaData) throws DeploymentException
 {
 try
 {
 // Pickup any deployment which doesn't have metaData or metaData with ejbVersion unknown or 3
 if(metaData != null && (metaData.isEJB2x() || metaData.isEJB1x()))
 {
 log.debug("Ignoring legacy EJB deployment " + unit);
 return;
 }
...

The problem with this is that if an ejb-jar.xml does not include any namespace (i.e. based on DTD) isEJB2x(), isEJB1x(), isEJB3x() will all return false.
Actually, the absence of ejbVersion should mean EJB2/EJB1 deployment because only these are allowed to use DTD.
ejb-jar_2_1.xsd and ejb-jar_3_0.xsd both define *required* and *fixed* attribute version with values 2.1 and 3.0 respectively.
So, any EJB3 deployment will have a non-null ejbVersion and isEJB3x() will return true.
So, I am going to change the "if" above to

if(metaData != null && !metaData.isEJB3x())
 {
 log.debug("Ignoring legacy EJB deployment " + unit);
 return;
 }

[jaikiran]

So, I am going to change the "if" above to

if(metaData != null && !metaData.isEJB3x())
 {
 log.debug("Ignoring legacy EJB deployment " + unit);
 return;
 }

Sounds good. Infact, we use this approach in one of our other deployers http://anonsvn.jboss.org/repos/jbossas/projects/ejb3/trunk/endpoint-deployer/src/main/java/org/jboss/ejb3/endpoint/deployers/EJB3EndpointDeployer.java

[wolfc]

Which means that this piece of logic should be on one common ground. Maybe an EJB3DeployerHelper?

[aloubyansky]

This is fixed as https://jira.jboss.org/jira/browse/JBAS-7070

[jaikiran]

"wolfc" wrote:
Which means that this piece of logic should be on one common ground. Maybe an EJB3DeployerHelper?

Yep, we can have it in our ejb3-deployers component. I'll create a task for this.

This is fixed as https://jira.jboss.org/jira/browse/JBAS-7070

Alexey, are you planning to do it in AS trunk too? If not, i'll update it in trunk.