@Unversioned once again

[morman]

Hello all.

I've tried @Unversioned annotation approach to disable versioning for referenced entities, and I have one suggestion. While it is good idea to have such "disabling" possibility this approach is not practical when have lot of entities.

I've tried to integrate envers in project with 50+ entities, where only a subset is versioned. It was horrible to add one @Versioned and several @Unversioned annotations and run application just to check where I missed the @Unversioned this time.

Why not use other approach. Simply assume that if entity is not explicitly @Versioned then it is implicitly @Unversioned. I've modified VersionsMetadataGenerator class in such way that instead of throwing MappingException it just returns. For me it works fine, and I think that this is better approach. I've modified only addToOne method while it was only needed for me. I don't analyse other methods and possible consequences of such modification ;).

What do you think about it?

Michal

[adamw]

Hello,

so, if I understand you right, you'd like to @Unversion all relations, which are between a versioned and non-versioned entities? Because if an entity isn't marked as @Versioned, then of course Envers won't even consider it.

Maybe a configuration option would be a good idea? Create a JIRA :)

Adam

[morman]

Configuration option may be a good idea, but it is worth of consideration if it is truly required to throw an exception if such relationship is found.

JIRA created :)

[nikodc]

What about some kind of "mappingExceptionOnRelationToNonVersioned" configuration property which by default is "false". I think that what Michal says is right and disabling the MappingException in general is the better approach. However I found it could be interesting to have the possibility to configure Envers to have the current behavior. For example, during development time, the Exception throwing strategy could be useful to easily detect references to unversioned entities in projects where the vast majority of the entities is supposed to be versioned. Suppose you add a new entity but forget about the @Versioned annotation.

[adamw]

Hello,

yes, I also think that a property is the best solution. Especially for the use case you describe :).

The JIRA issue is https://jira.jboss.org/jira/browse/ENVERS-45

Adam

[chris.simons]

I also think this would be a great idea; a property in persistence.xml, for example, to disable versioning of relationships by default.

I agree, the exceptions are kind of a pain - esp. when applying Envers to a bunch of entities.

[adamw]

Then go ahead and vote for the issue :)

--
Adam

[adamw]

The new link:
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3560