fileUpload keeps temp files open

[vladimirmanolov]

I am using the rich:fileUpload component with the createTempFiles option set to true in the web.xml.

When I upload a file it is written in my temp folder with a name similar to:
1bc2f35a-119380af625--7fff17206.upload

But my problem is that this file seems to be open and cannot be deleted or moved while the server is running. I wouldn't like to make a copy of it since I am using the fileUpload component for pretty large files. So my problem is how can I reuse the temp file without having to copy it or to shutdown the server? I am using RichFaces 1.2 and Tomcat 6.0

Any help is appreciated!

Thanks!

[vladimirmanolov]

Is the described behaviour supposed to be like this. If yes, am I doing something wrong by copying the tempFile in order for me to use it? This is what I do:

public void processUpload(UploadEvent event) {
 UploadItem uploadItem = event.getUploadItem();
 String fileName = uploadItem.getFileName();
 File file = uploadItem.getFile();

 File repository = getRepository();
 String target = repository.getAbsolutePath() + "/" + fileName;
 try {
 InputStream in = new FileInputStream(file);
 OutputStream out = new FileOutputStream(target);
 try {
 // Transfer bytes from in to out
 byte[] buf = new byte[1024];
 int len;
 while ((len = in.read(buf)) > 0) {
 out.write(buf, 0, len);
 }

 } finally {
 in.close();
 out.close();
 }
 ...

[sergeysmirnov]

I have added task to jira to check this issue.
http://jira.jboss.com/jira/browse/RF-3055
If somebody has something to say about this topic, please do it here or there.

[gizola]

Hi!

I use also fileupload with createTempFiles set to true.

But after file processing I can delete the file in code with File.delete(). I could also delete it manually from temp folder.

Try to delete the temp file from code after you successfully copied it to your Repository.

Regards,

Zola

[andrei_exadel]

Hi,

It was a bug. The problem was in unclosed fileOutputSream after request parsing.

This one was added into JIRA: http://jira.jboss.com/jira/browse/RF-3063.

Fixed.

Thanks for posting about this problem.

[vladimirmanolov]

Which version has the fix? Is it ok just to get the latest snapshot of RichFaces 1.2?

[andrei_exadel]

Yes. Try the latest SNAPSHOT.

[vladimirmanolov]

Thanks for the support. I tried the versions:

richfaces-api-3.2.1-20080415.044559-14.jar
richfaces-impl-3.2.1-20080415.044559-14.jar
richfaces-ui-3.2.1-20080415.044559-6.jar

and now it works. The temp file is closed after the upload. It can be deleted or renamed. I rename it in my upload listener so that it doesn't have a temp name but the name of the originaly uploaded file.

Thanks a lot!

[andrei_exadel]

In addition: new issue was found.

Temporary files could not be deleted if uploading process has been stopped by user.

This issue fixed in the following snapshot of 3.2.1.