Error in documentation regarding Implementation of DecisionH

[sebastian.s]

If you write your own Decision Class which has to implement DecisionHandler the documentation tells you to implement a method called select().

public class ContentEvaluation implements DecisionHandler {

 public String select(OpenExecution execution) {
 String content = (String) execution.getVariable("content");
 if (content.equals("you're great")) {
 return "good";
 }
 if (content.equals("you gotta improve")) {
 return "bad";
 }
 return "ugly";
 }
}

When I created my own class DecisionHandler made me implement a method called decide(). I think this an error in the docs and so it should be like this:

public class ContentEvaluation implements DecisionHandler {

 public String decide(OpenExecution execution) {
 String content = (String) execution.getVariable("content");
 if (content.equals("you're great")) {
 return "good";
 }
 if (content.equals("you gotta improve")) {
 return "bad";
 }
 return "ugly";
 }
}

[kukeltje]

in 3 it was decide, in 4 select. Can it be you imported the wrong decisionhandler interface?

[sebastian.s]

import org.jbpm.api.jpdl.DecisionHandler;

I added the jBPM User Libraries to my project and used Eclipse's QuickFix to generate the imports. Is this the old one?

[kukeltje]

nope the new one and I just now see the method signature uses the OpenExecution so I think it is an inconsistency in the docs as well.

[sebastian.s]

So it's necessary to file a JIRA for the documentation? It should be fixed for the new release since it's a very basic thing and can cause confusion for people following the docs to start with jBPM.

[kukeltje]

Yep, please do (you know your way around now do you ;-) but check if there are any open ones (or maybe even closed ;-))

[sebastian.s]

Hello Ronald,

I searched but could not find anything so I created a new issue in the good hope of not having overlooked something. ;)

https://jira.jboss.org/jira/browse/JBPM-2490