-
1. Re: JCR Feature completed - Need to add some dependencies
tom.baeyens Feb 27, 2006 4:15 AM (in response to jimrigsbee)go ahead. perfect.
adding dependencies: OK. i'll check with scott if we have to do anything special concerning the licenses on the included libs.
upgrading commons collections is no problem if the test suite runs fine.
one minor remark. hibernate and jboss contain a jta lib as well. is there any difference with the geronimo-spec-jta.jar ?
regards, tom. -
2. Re: JCR Feature completed - Need to add some dependencies
jimrigsbee Feb 27, 2006 7:27 AM (in response to jimrigsbee)I'll test without the geronimo jta spec.
Regards, Jim -
3. Re: JCR Feature completed - Need to add some dependencies
jimrigsbee Feb 27, 2006 7:41 AM (in response to jimrigsbee)Works fine without geronimo...removed it.
All work checked in and JIRA issue is closed.
Cheers, Jim -
4. Re: JCR Feature completed - Need to add some dependencies
tom.baeyens Feb 28, 2006 9:13 AM (in response to jimrigsbee)jim, could you also check in the libraries ?
afaict, you forgot to check them in.
regards, tom. -
5. Re: JCR Feature completed - Need to add some dependencies
jimrigsbee Feb 28, 2006 6:58 PM (in response to jimrigsbee)Tom,
From my vantage point they are all checked in...which ones do you find missing?
Thanks, Jim -
6. Re: JCR Feature completed - Need to add some dependencies
tom.baeyens Mar 1, 2006 3:54 AM (in response to jimrigsbee)found them. i must have been looking in the wrong branch...
thanks !
regards, tom. -
7. Re: JCR Feature completed - Need to add some dependencies
tom.baeyens Mar 1, 2006 4:09 AM (in response to jimrigsbee)just looked at the code. its great ! completely the jbpm style. you really understand how it works without any explanation. congrats.
there's only 1 minor thing that i would like to change with your approval: the service name 'repository', i would like to replace that with 'jcr' if that is ok with you. Also i would like to define a constant for that in the Services.
one other minor detail is the test naming scheme. All AbstractDbTestCase tests should end with DbTest. That naming convention is used in the ant test scripts. Not really important, but i thought i'ld let you know.
regards, tom. -
8. Re: JCR Feature completed - Need to add some dependencies
jimrigsbee Mar 1, 2006 7:09 AM (in response to jimrigsbee)Tom,
No problem with the change to JCR. I think you will find a constant in Services already that you can change to match. Please feel free to make the name change to the Db test or I'll do it next check in.
I'm glad you like the code. I think it is very important in open source for the code to be consistent. I appreciate how well you have things layed out, you made it easy!
Regards, Jim -
9. Re: JCR Feature completed - Need to add some dependencies
tom.baeyens Mar 1, 2006 7:38 AM (in response to jimrigsbee)one more thing... what is the jaas configuration for ? do you think we could turn off that security or make it configurable ?
regards, tom. -
10. Re: JCR Feature completed - Need to add some dependencies
edgarpoce Mar 1, 2006 7:59 AM (in response to jimrigsbee)AFAIK you can turn off jaas aware login by adding a few lines in the jackrabbit configuration file.
<LoginModule class="org.apache.jackrabbit.core.security.SimpleLoginModule"> <param name="anonymousId" value="anonymous"/> </LoginModule>
-
11. Re: JCR Feature completed - Need to add some dependencies
jimrigsbee Mar 1, 2006 9:15 AM (in response to jimrigsbee)The JAAS file is for jackrabbit.
This brings up an interesting point. I'm not sure that our add-on's like JCR which have specific configuration files really belong in src/config.files. Perhaps they belong in some examples or even the test directory?
Let me know what you think and I'll move them as appropriate.
Jim -
12. Re: JCR Feature completed - Need to add some dependencies
tom.baeyens Mar 1, 2006 9:32 AM (in response to jimrigsbee)yes. all those files belong in the test directory.
the config.files directory is intended for the default configurations that people can use to get started.
the trick is that you be creating your own JbpmConfiguration in the tests and not use the default one that searches for jbpm.cfg.xml
regards, tom. -
13. Re: JCR Feature completed - Need to add some dependencies
jimrigsbee Mar 5, 2006 4:11 PM (in response to jimrigsbee)I removed the JAAS.config file, thanks Edgar!
I renamed the service to jcr and added Db into the test names.
Regards, Jim