JCR Feature completed - Need to add some dependencies

[jimrigsbee]

Greetings,

I have completed the feature described in jira JBPM-113 http://jira.jboss.com/jira/browse/JBPM-113. The ability to store and retrieve content nodes in the process context map.

1 dependency will change and several new ones will be introduced. I wanted to make sure that we discuss this first before I check any code into the HEAD for version 3.2.

Jackrabbit 1.0 and JSR 170 (JCR 1.0) libraries are required for build and test. These dependencies must be added.

Jackrabbit introduces a change in 1 dependency: commons-collections. Currently the JBoss libraries bring this in at version 2.1. Jackrabbit needs 3.1 because it uses the new "map features".

Jackrabbit testing and client runtime usage introduces 4 dependencies:

* geronimo-spec-jta-1.0-M1.jar
* lucene-1.4.3.jar
* concurrent-1.3.4.jar
* xercesImpl - we already have this in lib but I added it to .classpath for testing inside of Eclipse


I ran AllTests within Eclipse and got success on all tests except for 1 Timer test failing (not related afaik). I did not seem to introduce any problems with these new dependencies locally.

Regards, Jim

[tom.baeyens]

go ahead. perfect.

adding dependencies: OK. i'll check with scott if we have to do anything special concerning the licenses on the included libs.

upgrading commons collections is no problem if the test suite runs fine.

one minor remark. hibernate and jboss contain a jta lib as well. is there any difference with the geronimo-spec-jta.jar ?

regards, tom.

[jimrigsbee]

I'll test without the geronimo jta spec.

Regards, Jim

[jimrigsbee]

Works fine without geronimo...removed it.

All work checked in and JIRA issue is closed.

Cheers, Jim

[tom.baeyens]

jim, could you also check in the libraries ?

afaict, you forgot to check them in.

regards, tom.

[jimrigsbee]

Tom,

From my vantage point they are all checked in...which ones do you find missing?

Thanks, Jim

[tom.baeyens]

found them. i must have been looking in the wrong branch...

thanks !

regards, tom.

[tom.baeyens]

just looked at the code. its great ! completely the jbpm style. you really understand how it works without any explanation. congrats.

there's only 1 minor thing that i would like to change with your approval: the service name 'repository', i would like to replace that with 'jcr' if that is ok with you. Also i would like to define a constant for that in the Services.

one other minor detail is the test naming scheme. All AbstractDbTestCase tests should end with DbTest. That naming convention is used in the ant test scripts. Not really important, but i thought i'ld let you know.

regards, tom.

[jimrigsbee]

Tom,

No problem with the change to JCR. I think you will find a constant in Services already that you can change to match. Please feel free to make the name change to the Db test or I'll do it next check in.

I'm glad you like the code. I think it is very important in open source for the code to be consistent. I appreciate how well you have things layed out, you made it easy!

Regards, Jim

[tom.baeyens]

one more thing... what is the jaas configuration for ? do you think we could turn off that security or make it configurable ?

regards, tom.

[edgarpoce]

AFAIK you can turn off jaas aware login by adding a few lines in the jackrabbit configuration file.

 <LoginModule
class="org.apache.jackrabbit.core.security.SimpleLoginModule">
 <param name="anonymousId" value="anonymous"/>
 </LoginModule>

[jimrigsbee]

The JAAS file is for jackrabbit.

This brings up an interesting point. I'm not sure that our add-on's like JCR which have specific configuration files really belong in src/config.files. Perhaps they belong in some examples or even the test directory?

Let me know what you think and I'll move them as appropriate.

Jim

[tom.baeyens]

yes. all those files belong in the test directory.

the config.files directory is intended for the default configurations that people can use to get started.

the trick is that you be creating your own JbpmConfiguration in the tests and not use the default one that searches for jbpm.cfg.xml

regards, tom.

[jimrigsbee]

I removed the JAAS.config file, thanks Edgar!

I renamed the service to jcr and added Db into the test names.

Regards, Jim