3 Replies Latest reply on Mar 29, 2007 7:12 PM by zipwow

    Guidance for JBPM-725?  Applies to 3.2?

    zipwow

      I ran into the issue described in JBPM-725 in jbpm 3.1:

      http://jira.jboss.com/jira/browse/JBPM-725
      Set auto-import="false" for all hibernate-mapping elements in hibernate mapping files.

      From a cursory glance of the 3.1 code, it looks like all (or the majority) of the hibernate queries are already written with fully qualified names, so I'm willing to tackle this change. Before I begin:

      Would it make sense to do this against the 3.2 codebase instead?
      Are there any pitfalls I should be aware of?
      Where should I look for the baseline of expected passing unit tests? (I seem to get some failures out of the box for 3.1)

      Thanks,

      Kevin Klinemeier

        • 1. Re: Guidance for JBPM-725?  Applies to 3.2?
          tom.baeyens

          thanks for bringing that up. it's a good poit and it would be great if you could help us with that.

          did you already sign a contributors agreement ? if not, see the jbpm wiki oncontributions and check Cotributors Agreement in the left menu of labs.jboss.org (you have to be logged in to sign an agreement)

          once that is done, you can get cvs commit access to apply ths change.

          • 2. Re: Guidance for JBPM-725?  Applies to 3.2?
            zipwow

            Looks like I missed this reply, I did sign the agreement. Once I have cvs access, assuming this change is still relevant, what tag/branch should I check this change into?

            • 3. Re: Guidance for JBPM-725?  Applies to 3.2?
              zipwow

              I checked in the fix for this for jpdl and identity sources to jbpm.3 head, did not change the mapping files for BPEL as I'm not set up to compile/test that part of the project.

              I updated one named query to use the fully-qualified name for Token, looks like that's the correct style anyway based on all the other named queries.

              All tests passed, save the email tests which my antivirus dislikes.

              I sent a note to labs-admin to see about getting permission to update the JIRA issue.

              -Kevin