gpd deployer jar

[tom.baeyens]

i see you included the gpd deployer jar again. previously i moved the jar to including the classes. afaict i removed the building of the jar file. so the gpd deployer jar probably doesn't even exist.

or did i miss something ?

[tom.baeyens]

ah. the build seems to fail on that, so i'll remove it for now.

[dmlloyd]

Why did you merge the classes in? I made it a jar deliberately so that it would be easy to remove. I strongly advise that either this is a separate jar within the WAR, or that a separate WAR be created for this.

[dmlloyd]

Incidentally, the reason I added those lines back in is that they were removed from only one of the two WAR targets, so I figured it was removed mistakenly.

[tom.baeyens]

ok. then we're on the same page.

i just used straight classes to move quickly. and i assumed you just re-added the gpd-deployer jar assuming it was missing.

so if you want, you can fix it to go back to a jar file, but that you would also have to reintroduce the building of the jar file. imo you're right, but it should be no priority over the other console enhancements.

[tom.baeyens]

i see you also reverted to the gpd-deployer sources folder. the main and test are conform the maven naming and we used it all over the project.

why do you want an exception there ? why is main not good ?

[dmlloyd]

Just because those are not the main sources for the console. If we were to add additional removable servlets (which compile to jars), they also would get their own directories. If there was ever to be java code that pertains specifically to the console, that would go in src/main/java.

[tom.baeyens]

no. that is not the way that it was intended. in the case you mention, you should work with subprojects (like in the jpdl project).

each project has the same base structure and should produce 1 product. (though this can not really be the case)

so if you want to move it to a separate source folder, you should create a separate project. not just another dir next to 'main'

also, i think the class *should* go into the main console sources. it's not a separate reusable component that is used in many other components. it is a class that is used in the console. the security issue needs to be handled differently. with configuration options, good defaults and easy ways of changing the configuration. not with cluttering the development source structure.

[dmlloyd]

Well, the problem with that logic is that the gdp deployer has no relationship whatsoever with the console; it is part of the gdp that just has to reside within the app server. In fact, it might be better to put the code for this servlet inside of jbpm-jpdl.jar itself, much like the timer servlet.

The test is, if there was no console, how would it be done? The answer is that it would be in jbpm-jpdl.jar and there would be a stub .war file to run the jBPM servlet components.

So, what do you think about moving the servlet code into the jPDL jar?

[tom.baeyens]

moving the servlet to jpdl/jar/src/main/java is a good alternative.

[dmlloyd]

Ok, done.

[tom.baeyens]

did you check if the suite distribution still works ?