5 Replies Latest reply on Jun 29, 2009 4:43 AM by tom.baeyens

    can tests import impl ?

    tom.baeyens

      currently, the maven modules of the core engine are organised in such a way that user code and their test code does not have to import stuff from the pvm or jpdl libs. only api, log and test-base.

      if we are ok with user test classes having to have the pvm lib on the compile time classpath, then we can merge the log and test-base modules in the pvm.

      still users would be able to write their client code with a single dependency on the jbpm-api module.

      thoughts ?

        • 1. Re: can tests import impl ?
          tom.baeyens

          similar question for enterprise module.

          does anyone see a reason why we should not merge that into the pvm module ?

          • 2. Re: can tests import impl ?
            tom.baeyens

            also i think the integration-spi module could be merged into the pvm.

            same as for enterprise, the dependencies could be declared in maven with scope 'provided'

            • 3. Re: can tests import impl ?
              camunda

              For the sake of simplicity that sounds like a good idea.

              What is the downside of it? That you "accidently" could use PVm classes where the API should be used? Or...?

              • 4. Re: can tests import impl ?
                jbarrez

                But does the conceptual picture holds: ie does the enterprise module belongs to the PVM??

                • 5. Re: can tests import impl ?
                  tom.baeyens

                   

                  "camunda" wrote:
                  What is the downside of it? That you "accidently" could use PVm classes where the API should be used? Or...?


                  yes. that we allow users to *guarantee* that they are only using stable api by only depending on the api package.

                  the question is if this should also be expanded to tests. that imposes a couple of additional problems like test-base and e.g. the logging (test-base classes want to log...)

                  if we keep the split of these libs as it is now, we allow users to write their tests also with only using stable api and stable test support classes.

                  currently our tests still have a pvm dependency in the pom. so either we need to fix this or we should merge the libs.