Add schema binding to SingletonSchemaResolverFactory

[sguilhen]

I am about to commit the implementation of a metadata factory for security policies. This factory allows for the declaration of policies in -beans.xml files using security tags:

<deployment xmlns="urn:jboss:bean-deployer:2.0">

 <application-policy xmlns="urn:jboss:security-beans:1.0" name="TestPolicy1">
 <authentication>
 <login-module code="org.jboss.security.auth.spi.UsersRolesLoginModule" flag="required">
 <module-option name="usersProperties">jboss-users.properties</module-option>
 <module-option name="rolesProperties">jboss-roles.properties</module-option>
 </login-module>
 </authentication>
 </application-policy>

 .....
</deployment>

the AppPolicyBean generated by the factory registers the application policy described with the security layer.

What I need is to add a definitive binding for the security schema to the SingletonSchemaResolverFactory for the policies to be used in the AS. In my tests I'm doing that explicitly during the setUp method:

 SingletonSchemaResolverFactory.getInstance().addJaxbSchema("urn:jboss:security-beans:1.0",
 "org.jboss.security.microcontainer.beans.metadata.SecurityPolicyMetaData");

Is it ok if I add myself this binding and commit it?

[aloubyansky]

Yes. Also, please, create a Jira issue in the JBXB for this. Thanks.

[anil.saldhana]

Alexey, shouldn't this registration sit in the security integration layer rather than XB?

[alesj]

You can/should create your own deployer, that knows how to parse your custom security xml, plus it registers your schema/metadata to resolver.

This way you can then use your custom xml in -beans.xml and your e.g. -security.xml.

Stefan knows how to do this, or see SchemaResolverDeployer for more info.

[aloubyansky]

Yes, I would say logically the resolver configuration and all the mappings (including the existing ones) should be done on the integration level. The mappings reference class names from other projects and it makes sense for the owners of those classes to be able to make changes in this area w/o requesting a change in the xb's sourcecode.