2 root elements question

[aloubyansky]

"Jeff" wrote:
Here I have a question.
For ds.xml, there are 2 root elements defined in the DTD file jboss-ds_5_0.dtd
"datasources" and "connection-factories".
How can I handle these in our metadata project?

And if we want use xsd file to re-define ds.xml, we must change it into single root XML document tree, right?
I would like to add an element to wrap them as new root element, but I am concerned for compatibility with Jboss old version.
Do you have good idea?

Thanks
Jeff

[aloubyansky]

XML schema can contain multiple top-level/root elements. The corresponding classes have to be annotated with @XmlRootElement.

The problem is at the moment JBossXBBuilder (which is a SchemaBinding producer) takes only one class (which may reference other classes annotated with @XmlRootElement).

Until support for binding a set of classes to the same SchemaBinding is supported, there could be a few workarounds/hacks:
- just introduce an artificial class (which doesn't have to have a representation in the xsd) that would reference your top-level classes;
- build separate SchemaBinding's for datasources and connection-factories and then merge them into one.

The first one should be easier. Adding support for that to JBossXBBuilder should not be a problem as well. I am not sure whether JAXB defines a standard way to do that.

[jeff.zhang]

Thanks Alex.
I will try 1st way.

We had looked JAXB document but not find the standard way. We will search more article on Internet. And if you have more idea, please tell me. :)

[aloubyansky]

Here is the issue I am going to work on this week.
https://jira.jboss.org/jira/browse/JBXB-169

[jeff.zhang]

I would like use this feature. ;)
I had notice there is jbossxb-2.0.1.Beta1.jar in svn repo, is it ok if I change metadata pom.xml to use xb 2.0.1B1?

To use 2 roots, I could just follow usage of testcase, like
SchemaBinding schema = JBossXBBuilder.build(MainRootMainNs.class, YetAnotherRootMainNs.class, AnotherRootMainNs.class);
is it correct?

Thanks a lot

[aloubyansky]

Sure.

[jeff.zhang]

Hi Alex,

Could you give me some tip about how to use this feature in the metadata test framework?
Almost testcase use like this:
public static SchemaBindingResolver initResolver()
{
DefaultSchemaResolver resolver = new DefaultSchemaResolver();
resolver.addClassBindingForLocation("jboss-ds_5_0.xsd", ManagedConnectionFactoryDeploymentGroup.class);
return resolver;
}
And unmarshal.

I tried and another root element class into resolver, but testcase fail. I saw your change (Revision 2956) only modify JBossXBBuilder and JBossXBNoSchemaBuilder. That mean the testcase should use these XBBuilder directly? Thanks

[aloubyansky]

Ah, I didn't think about adding this to the resolver. You can try a workaround using the examples in the testsuite and SchemaBindingInitializer.
I'll add support for multi-class binding to the resolver.

[jeff.zhang]

Thanks Alex.
Please noticed me when we have multi-class binding resolver.

And do you have plan to release 1.0.0CR17 this week?

[aloubyansky]

Ok. Whether I release CR17 depends on whether I complete the next cleaning step. Hopefully so. Let me know if it's a blocker for you.

[jeff.zhang]

Thanks

[aloubyansky]

The resolver issue is https://jira.jboss.org/jira/browse/JBXB-185

It's done now. I'm gonna look into JBXB-182 and then release the XB. And after that the next metadata CR.

[jeff.zhang]

Cool!
So our tests initResolver() should like this: ?
public static SchemaBindingResolver initResolver()
{
MultiClassSchemaResolver resolver = new MultiClassSchemaResolver();
resolver.addClassBindingForLocation("jboss-ds_5_0.xsd", ManagedConnectionFactoryDeploymentGroup.class, ConnectionFactoryDeploymentGroup.class);
return resolver;
}

I will go those testcases done after JBXB 2.0.1 Beta 2 release.

[aloubyansky]

That's the idea. Metadata has been updated to use XB-2.0.1.Beta2.

[jeff.zhang]

tests passed!
Thanks Alex...

I can resolved some JIRAs for metadata. ;)