Closing hibernate sessions

[martingi]

Hello, I have a question concerning hibernate with the portal. For my application I followed
http://docs.jboss.org/jbossas/getting_started/v4/html/hibernate.html
and deploy the mappings inside a *.har, which is inside an *.ear - no problem.

To get the Session I'm using JBP code from org.jboss.portlet.forums.impl.ForumsModuleImpl#getSession

SessionFactory sf = (SessionFactory)new InitialContext().lookup("java:/portal/SessionFactory");
 Session session = sf.getCurrentSession();
 return session;
 }
 catch (NamingException e)
 {
 throw new RuntimeException(e);
 }

For the queries I looked at other methods from ForumsModuleImpl and I saw that the sessions are never closed here. However in the above linked docs they are closed in a finally block. Is this not necessary because the container somewhat takes care about this?

Thanks
Martin

[julien1]

indeed JBoss Portal takes care of closing the session when the request is finished and the session must be closed.

[alesj]

This is all taken care by Hibernate - when using SessionFactory.getCurrentSession().

But it depends on the active transaction - which is delivered to you by JBoss Portal (in v2.0 by TransactionFilter, in v2.2 by TransactionInterceptor).

The thing that finally closes your session is the ability of JTA synchronization registry. So your session is closed when underlying transaction is complete.

[julien1]

well said Justin