ActionRequestImpl.getWindowState throws a NullPointerExcepti

[gzbigegg2005]

hi,

I am getting this error message when trying to run my Tapestry portlet in JBoss Portal 2.2.1RC1:

org.jboss.portal.portlet.impl.ActionRequestImpl.getWindowState(ActionRequestImpl.java:58)

I had some similar problem of NullPointerException at org.jboss.portal.portlet.impl.ActionRequestImpl.getPortletMode(ActionRequestImpl.java:45) when I was using JBoss Portal 2.2. I found a JIRA issue related to this problem @ http://jira.jboss.com/jira/browse/JBPORTAL-539, so I tried to upgrade to 2.2.1RC1. The new version does resolve the getPortletMode() problem, but still having getWindowState() problem.

I also tried to compile 2.4 using the latest code from CVS, but still no luck, the same problem exists in 2.4 too.

Are they the same problems?

Regards,
Liu Yan

[julien1]

it looks like it could be. I will investigate

[julien1]

I fixed it in 2.4 and 2.2, thanks for the report.

[gzbigegg2005]

hi Julien,

Thanks for your quick reply. Actually I didn't expect such quick response, so I fixed it at my side and was planning to submit a patch. Anyway, I tested the fixes and it works very well.

Just a quick question, in the PortletRequestImpl.isPortletModeAllowed(PortletMode), there is a null test on the argument. I think the same should be applied to the method PortletRequestImpl.isWindowStateAllowed(WindowState).

Regards,
Liu Yan