portal-themes.xml is destructive to theme HTML

[bgmccollum]

I do not like the fact that my HTML assets in portal-themes.xml are mangled by JBoss portal. I consider this a bug and it should be fixed immediately. It is present in 2.4 and 2.6 DR1.

Please do not change my double quotes to single quotes.
Please do not change my empty script tags to self closing script tags.
Please do not add extraneous spaces (Look between script and src).
Please do not strip any of my attributes (charset is missing).

For example, in portal-themes.xml...

<script type="text/javascript" charset="utf-8" src="/themes/mytheme/scripts/lib/overlib.js"></script>

...Becomes...

<script src='/portal-core/themes/mytheme/scripts/lib/overlib.js' type='text/javascript' />

When you do this, IE thinks everything after the script tag is JavaScript source, so the whole page ends up being rendered as a blank page.

Please, just try to no think for me, cause you keep doing things wrong...utterly wrong...

[halversp]

This is not a bug, it's normal and appropriate canonicalization of XML. With the exception of dropping the charset attributes, all of these items are legitimate XML transformations which should not affect the behavior of any compliant XML parser. The two example fragments you describe are completely equivalent (again, other than the missing attribute).

p

[bgmccollum]

No it is not appropriate. You MUST always close a script tag explicitly, even when you supply a src attribute. If you don't, certain user agents think everything after the srcipt tag is JavaScript code. Thus, the page will be rendered as a blank page.

It is a bug. Fix it.

[roy.russo]

Can you create or link to the jira case?

Or is it easier for you to just sit here and whine all day?

[bgmccollum]

http://jira.jboss.com/jira/browse/JBPORTAL-1105

[roy.russo]

Fixed in 2.4 and 2.6 codebase. Thanks.

[bgmccollum]

Awesome! And sorry for being an ass. Totally not my style. I was just having a terrible day and was venting...

[roy.russo]

No problem. I'm an ass every day of my life. ;-)

We want more educated comments/cases like this one for portal, so thanks for reporting it.

[dewara]

I have run into a problem which is related to this.

Namely:

JBPORTAL-1173 - Injecting in portal page using jboss-portlet.xml does not produce closing tag.

http://jira.jboss.com/jira/browse/JBPORTAL-1173


I am using JBOSS portal 2.4.1. I can't actually inject javascript into the header using jboss-portlet.xml as the missing closing script tag seems to be causing my browser to regard the remaining html as javascript.

Has this issue been fixed in later versions of jboss portal or is therea workaround somebody knows of?