[anil.saldhana]

Any status update on the consolidated metadata work?

I need the <security-role> elements defined in jboss-app,jboss or jboss-web.xml merged into the metadata.

Before the new deployers, the metadata merge was done for web/ejb2 deployments.

[starksm64]

This needs to be merged at the lower jboss parsing deployers. For example, this code to find a web-context default from the ear in the AbstractWarDeployer really needs to be in the JBossWebAppParsingDeployer.

import org.jboss.deployers.plugins.deployers.helpers.AttachmentLocator;

 // Check for an ear level specification
 if( webContext == null )
 {
 J2eeApplicationMetaData earMetaData = AttachmentLocator.search(unit, J2eeApplicationMetaData.class);
 if( earMetaData != null )
 {
 String path = unit.getRelativePath();
 J2eeModuleMetaData webModule = earMetaData.getModule(path);
 if( webModule != null )
 webContext = webModule.getWebContext();
 }
 }

Something like:

 @Override
 public void deploy(DeploymentUnit unit) throws DeploymentException
 {
 log.debug("deploy, unit: "+unit);
 createMetaData(unit, webXmlPath, null);
 WebMetaData metaData = getMetaData(WebMetaData.class.getName());
 J2eeApplicationMetaData earMetaData = AttachmentLocator.search(unit, J2eeApplicationMetaData.class);
 if( earMetaData != null )
 {
 String path = unit.getRelativePath();
 J2eeModuleMetaData webModule = earMetaData.getModule(path);
 ...
 }

 }

[starksm64]

I have added the ear to module merge of the security roles to the JBossWebAppParsingDeployer and JBossEjbParsingDeployer. The ejb metadata class does not have a security roles merge function like the web tier does though, so that needs to be added.

[anil.saldhana]

I will make the changes to the ejb metadata class when I start with the cts tomorrow.

[anil.saldhana]

Can we pull out the importXXX methods out of the metadata classes into external classes? They are lengthy and not used anymore.

[starksm64]

No, they are still referenced by legacy code so let's not break the build for this.

[anil.saldhana]

I added the merge security roles method into ApplicationMetaData class.

Regarding the pullout of the importxxx methods, can we do them eventually, maybe after Beta1?

[starksm64]

Until we have aligned on the ejb3 refactoring and have defined how the integration with legacy servers will be done there is no need to drop the code.