1 2 3 Previous Next 34 Replies Latest reply on Jul 9, 2007 3:58 PM by brian.stansberry Go to original post
      • 30. Re: @JMX aspect and aop/mc integration
        starksm64

        Support for enum properties has been added.
        http://jira.jboss.com/jira/browse/JBMICROCONT-110

        • 31. Re: @JMX aspect and aop/mc integration
          brian.stansberry

          Do we still want to do the AUTO/STRICT/NONE approach. I moved away from this to do AS 5 Beta1 stuff and forgot about this.

          It's simple enough to add AUTO/STRICT/NONE. Just need to decide how to handle the registerDirectly attribute since it's been around a while.

          1) It has the same meaning as STRICT, so we can deprecate it and javadoc it as causing STRICT behavior if set to true and the annotation is configured for AUTO (the default). Otherwise it has no effect. This means usages that specified registerDirectly=true or didn't deploy a standard mbeanl get consistent behavior. The (probably nonexistent) cases of someone who deployed a valid standard mbean but wanted a proxy registered anyway will break.

          2) Remove it and accept complaints about an API change between a beta and a CR.

          I'd say go with #1.

          • 32. Re: @JMX aspect and aop/mc integration
            brian.stansberry

            Hmm. Seems AUTO is not totally trivial. It's easy to validate whether a given class is either a DynamicMBean or meets the standard mbean naming rules.

            But, @JMX has a required exposedInterface attribute. So, we have to validate that the bean is a valid mbean with respect to the given interface. Simple enough for the standard mbean check, but if the bean is a DynamicMBean, that basically means examining all the methods in the exposedInterface and checking the bean's MBeanInfo to confirm that there is a matching attribute or operation.

            Doable, but involves a fair amount of code and a lot of testing. So, back to the original question: Do we still want to do the AUTO/STRICT/NONE approach? The advantage versus the existing registerDirectly is a small ease of use benefit whereby users don't have to add registerDirectly=true to their annotation.

            • 33. Re: @JMX aspect and aop/mc integration
              alesj

              I guess we can keep registerDirectly, it's plain and simple.
              And we want to move people away from MBeans anyway ... go POJOs. :-)

              • 34. Re: @JMX aspect and aop/mc integration
                brian.stansberry

                OK. I've closed JBMICROCONT-109. If you ever want to resurrect AUTO, let me know. I spent a couple hours on it and did a fair bit before I began dreading all the unit tests of DynamicMBean validation. I kept a copy of that stuff.

                1 2 3 Previous Next