-
1. Re: Regression in Smoke Test - WebIntegrationUnitTestCase
starksm64 Jul 16, 2008 8:05 PM (in response to alrubinger)I would not expect that any of the WebIntegrationTestCase refs would need to fallback to the ejb interface for resolution, so an ejb-ref or ejb-local-ref is not being picked up or resolved. I'll take a look at the test.
-
2. Re: Regression in Smoke Test - WebIntegrationUnitTestCase
alrubinger Jul 16, 2008 9:49 PM (in response to alrubinger)Though not relevant for the Web Integration tests, there's definitely some stuff amiss here. For example, I'm considering the following (as exposed by EJB3 Integration TestSuite "bank" test):
Index: server/src/main/org/jboss/deployment/MappedReferenceMetaDataResolverDeployer.java =================================================================== --- server/src/main/org/jboss/deployment/MappedReferenceMetaDataResolverDeployer.java (revision 75930) +++ server/src/main/org/jboss/deployment/MappedReferenceMetaDataResolverDeployer.java (working copy) @@ -390,6 +390,8 @@ { // Add ejb/vfsPath@iface String remote = sbean.getRemote(); + String remoteJndiName = sbean.determineResolvedJndiName(remote); + cdmd.addJndiName(remoteJndiName); String ifacePath = prefix + "@" + remote; if(endpointAlternateMap.containsKey(ifacePath)) log.debug(ejbName+" duplicates remote: "+remote+", existing: "+endpointAlternateMap.get(ifacePath)); @@ -451,6 +453,8 @@ { // Add ejb/vfsPath@iface String local = sbean.getLocal(); + String localJndiName = sbean.determineLocalJndiName(); + cdmd.addJndiName(localJndiName); String ifacePath = prefix + "@" + local; if(endpointAlternateMap.containsKey(ifacePath)) log.debug(ejbName+" duplicates local: "+local+", existing: "+endpointAlternateMap.get(ifacePath)); @@ -537,8 +541,8 @@ } // Add ejb/iface ifacePath = "ejb@" + remote; - if(endpointAlternateMap.containsKey(ifacePath)) - log.debug(ejbName+" duplicates business-remote: "+remote+", existing: "+endpointAlternateMap.get(ifacePath)); + if(endpointMap.containsKey(ifacePath)) + log.debug(ejbName+" duplicates business-remote: "+remote+", existing: "+endpointMap.get(ifacePath)); else { endpointAlternateMap.put(ifacePath, ejbCompID);
S,
ALR -
3. Re: Regression in Smoke Test - WebIntegrationUnitTestCase
alrubinger Jul 16, 2008 9:59 PM (in response to alrubinger)Eh, forget that patch. It satisfies an unmet demand, but the demand is bogus anyway as those bindings won't ever be made.
S,
ALR -
4. Re: Regression in Smoke Test - WebIntegrationUnitTestCase
alrubinger Jul 16, 2008 11:13 PM (in response to alrubinger)This patch brings the WebIntegrationUnitTestCase back in line:
Index: server/src/main/org/jboss/deployment/MappedReferenceMetaDataResolverDeployer.java =================================================================== --- server/src/main/org/jboss/deployment/MappedReferenceMetaDataResolverDeployer.java (revision 75930) +++ server/src/main/org/jboss/deployment/MappedReferenceMetaDataResolverDeployer.java (working copy) @@ -390,6 +390,8 @@ { // Add ejb/vfsPath@iface String remote = sbean.getRemote(); + String remoteJndiName = sbean.determineJndiName(); + cdmd.addJndiName(remoteJndiName); String ifacePath = prefix + "@" + remote; if(endpointAlternateMap.containsKey(ifacePath)) log.debug(ejbName+" duplicates remote: "+remote+", existing: "+endpointAlternateMap.get(ifacePath)); @@ -451,6 +453,8 @@ { // Add ejb/vfsPath@iface String local = sbean.getLocal(); + String localJndiName = sbean.determineLocalJndiName(); + cdmd.addJndiName(localJndiName); String ifacePath = prefix + "@" + local; if(endpointAlternateMap.containsKey(ifacePath)) log.debug(ejbName+" duplicates local: "+local+", existing: "+endpointAlternateMap.get(ifacePath)); @@ -537,8 +541,8 @@ } // Add ejb/iface ifacePath = "ejb@" + remote; - if(endpointAlternateMap.containsKey(ifacePath)) - log.debug(ejbName+" duplicates business-remote: "+remote+", existing: "+endpointAlternateMap.get(ifacePath)); + if(endpointMap.containsKey(ifacePath)) + log.debug(ejbName+" duplicates business-remote: "+remote+", existing: "+endpointMap.get(ifacePath)); else { endpointAlternateMap.put(ifacePath, ejbCompID); @@ -946,7 +950,7 @@ // Determine the jndi name for the reference interface String iface = getInterface(ref); //LegacyEjb3JndiPolicy policy = new LegacyEjb3JndiPolicy(); - String containerJndiName = target.getBeanMetaData().determineResolvedJndiName(iface); + String containerJndiName = target.getBeanMetaData().determineJndiName(); if(containerJndiName != null) ref.setResolvedJndiName(containerJndiName); }
I'm testing against some of the other testsuites locally now to see what impact this has elsewhere.
S,
ALR -
5. Re: Regression in Smoke Test - WebIntegrationUnitTestCase
alrubinger Jul 16, 2008 11:30 PM (in response to alrubinger)Committed to r75934.
Easily rolled back tomorrow if this breaks other stuff, but it handles all but one of my regressions to the smoke tests.
S,
ALR -
6. Re: Regression in Smoke Test - WebIntegrationUnitTestCase
alrubinger Jul 17, 2008 1:17 AM (in response to alrubinger)Looks good:
http://jboss.hudson.alrubinger.com/job/AS_TestSuite_Smoke_Tests/15/
And my local TCK run was unaffected.
S,
ALR