-
1. Re: New Remoting Integration Project
alrubinger Jul 26, 2008 5:41 PM (in response to alrubinger)There's an older discussion on this here:
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4147407
...where Carlo says that the dependency is OK. I disagree; if I want to use a remoting aspect in my project I don't want to bring in Security or Tx because a Util class is in the wrong place. :)
S,
ALR -
2. Re: New Remoting Integration Project
starksm64 Jul 26, 2008 6:25 PM (in response to alrubinger)So remove those dependencies and inject them if they are really needed.
-
3. Re: New Remoting Integration Project
alrubinger Jul 26, 2008 8:17 PM (in response to alrubinger)Spell it out for me? Unclear.
S,
ALR -
4. Re: New Remoting Integration Project
brian.stansberry Jul 27, 2008 10:18 AM (in response to alrubinger)Not sure if this was what Scott meant, but the dependencies come via the Remoting.makeRemotable(InstanceAdvised proxy, InvokerLocator locator, Object objectId) method, which AFAICT isn't used anywhere. If someone wanted to get the same functionality they can create the equivalent interceptor list and call makeRemotable(InstanceAdvised proxy, InvokerLocator locator, Object objectId, List interceptors, String subsystem). So drop the convenience method.
If you're concerned about dropping the method in a CR2, copy the class back to the AS project aspects module. Then create a different class in remoting-aspects, e.g. RemotingUtil with the same behavior x-the offending method. The class in the aspects module delegates to RemotingUtil.
There was an equivalent class in aspects called ClusteredRemoting. Had same problem and no one was using it. When I pulled the clustering stuff out of aspects I just left that one there in case an end user wanted it. -
5. Re: New Remoting Integration Project
alrubinger Jul 27, 2008 12:09 PM (in response to alrubinger)I like your style, Stansberry.
Added comment to the ticket, so I'll get to this once I get to the bottom of what/who broke the Unit Tests in there.
S,
ALR -
6. Re: New Remoting Integration Project
starksm64 Jul 28, 2008 10:58 AM (in response to alrubinger)Yes, that is what I meant.