jboss-threads brought into jbossas repository...

[dmlloyd]

...and I've mostly finished (locally) a basic integration of the deployer into AS 5.x. I'm probably going to finish it fully tonight, and then have a look around to see if there's anything that can/should be moved to it, and if there's any glaring omissions that need to be addressed before Beta1.

In particular, I feel like I should have a more comprehensive integration with the existing ThreadPool stuff. Though looking around, I don't see any in-AS users that are really doing anything with it other than just .run() (other than JBossWorkManager), so maybe these things ought to just be moved over to use Executor instead...? Maybe that's a task for some other time.

Anyway, failing any of that, I'll move on to integrating XNIO tomorrow...

See http://anonsvn.jboss.org/repos/jbossas/projects/jboss-threads/trunk/. Any comments, let me know. I guess I'll have The Dudes start up a JBTHR JIRA project, what do you guys think?

[dmlloyd]

Done. I put the sole XML file in varia, and use the varia build step to assemble the deployer - if that's not OK, let me know. Otherwise I'll probably do the same for the other new deployers which are structured similarly.

[dmlloyd]

Here's an interesting problem. I've introduced jboss-threads into the deployers/ folder so that it's available to deployments. However, there's no guarantee that it will be available to other deployers, since they may be deployed before it.

What's the best solution? Some kind of ordering directive? A pre-deployer deployers folder? Maybe make the threads deployer part of the bootstrap process somehow?

[dmlloyd]

To expand a little - I would rely on the dependency mechanism but since there's a parser involved, it seems that it won't even parse a jboss-beans.xml which contains a "threads" tag, or a deployment which includes a jboss-threads.xml, even if there is a directive to indicate that it depends on the threads deployer bean...

[adrian.brock]

Here's an interesting problem. I've introduced jboss-threads into the deployers/ folder so that it's available to deployments. However, there's no guarantee that it will be available to other deployers, since they may be deployed before it.

What's the best solution? Some kind of ordering directive? A pre-deployer deployers folder? Maybe make the threads deployer part of the bootstrap process somehow?

Deployers don't need to manage threads they just process metadata.

[dmlloyd]

Deployers don't need to manage threads they just process metadata.

Ah. I was thinking from the perspective of the forthcoming XNIO deployer, which I was thinking would set up the thread stuff and the base provider as well as installing the actual deployer; though looking at it this way, those pieces probably should be considered a deployment and go into an "xnio-jboss-beans.xml" in deploy, which makes the whole issue disappear...

[dmlloyd]

I've had a bug tracker created for this subproject at https://jira.jboss.org/jira/browse/JBTHR.