ProfileService Server.getMetadata() - immutable OK?

[alrubinger]

Probably this one's for Scott/Emanuel:

http://anonsvn.jboss.org/repos/jbossas/projects/bootstrap/trunk/spi-as/src/main/java/org/jboss/bootstrap/spi/as/server/JBossASBasedServer.java:

/**
 * Get the optional server configuration metadata
 *
 * @return A possibly empty map of configuration metadata
 */
 Map<String, Object> getMetaData();

Can I wrap this in Collection.unmodifiableMap() when returning so we don't leak out the mutable state of the server? Or is something in the ProfileService depending upon altering the contents?

S,
ALR

[alrubinger]

JIRA pending approval: https://jira.jboss.org/jira/browse/JBBOOT-104

S,
ALR

[starksm64]

It would be purely a one-way mechanism of passing in bootstrap environment properties, so an immutable map is fine.