[alesj]

Without that nothing really knows that it should look for the IB, which is registered in MC under a different name from the bean we actually want to install, and try to uninstall that. WKCCC could contain the registry and handle this.

Yeah, this looks like the least invasive way of doing this.
But I wouldn't go again checking all KCCCs, as we already know who handled that BMD.
e.g. we could keep a Map(Object, KCCC) where BMD::getName is the key.

[kabirkhan]

Cool,

Should I rename KCCC to something more descriptive like BeanMetaDataDeployerPlugin?

[alesj]

Should I rename KCCC to something more descriptive like BeanMetaDataDeployerPlugin?

I guess so, as we don't just create KCC anymore.

[kabirkhan]

As discussed privately I have changed things a bit. Here's the current state of play.

In the deployers, I create WeldKernelControllerContexts for the MC beans if they are part of a deployment that contains weld deployments. The WeldKernelControllerContext has a reference to the BeanManager which is then used for injection from Weld to MC beans.

Only MC beans with the @WeldEnabled annotation are available for injection from MC to Weld (you can/should of course use qualifier annotations etc. in addition to this). I created a WeldEnabled annotation plugin to handle this annotation and add the beans to the McFromWeldRegistry. This means that @WeldEnabled MC beans that are not part of a deployment containing Weld beans are available for injection to Weld beans in later deployments.

[kabirkhan]

I have committed the work done for this for https://jira.jboss.org/jira/browse/WELDINT-29

Ales, can you please take a quick look at https://svn.jboss.org/repos/jbossas/projects/weld-int/trunk/deployer-mc-int/src/test/java/org/jboss/test/deployers/test/McIntegrationTestCase.java and see if there are some tests I have not thought of?

[alesj]

Ales, can you please take a quick look at https://svn.jboss.org/repos/jbossas/projects/weld-int/trunk/deployer-mc-int/src/test/java/org/jboss/test/deployers/test/McIntegrationTestCase.java and see if there are some tests I have not thought of?

Hmmm ... failures:

Tests in error:
 testWeldDeployment(org.jboss.test.deployers.test.McIntegrationTestCase)
 testWeldAndMcDeployment(org.jboss.test.deployers.test.McIntegrationTestCase)
 testMcInjectedByWeld(org.jboss.test.deployers.test.McIntegrationTestCase)
 testWeldInjectedByMc(org.jboss.test.deployers.test.McIntegrationTestCase)
 testMcInjectedIntoWeldInjectedIntoMc(org.jboss.test.deployers.test.McIntegrationTestCase)
 testWeldInjectedIntoMcInjectedIntoWeld(org.jboss.test.deployers.test.McIntegrationTestCase)
 testExternalMcBeanInjectedIntoWeld(org.jboss.test.deployers.test.McIntegrationTestCase)
 testExternalMcBeanInjectedIntoWeld2(org.jboss.test.deployers.test.McIntegrationTestCase)

Tests run: 10, Failures: 0, Errors: 8, Skipped: 0

[INFO] ------------------------------------------------------------------------
[ERROR] BUILD FAILURE

[alesj]

"alesj" wrote:

Hmmm ... failures:

OK, another JDK5 vs. JDK6 issue:

47 [main] INFO Weld/Version - WELD-000900 1.0 (0)
5640 ERROR [AbstractKernelController] Error installing to Create: name=vfs://top-level.ear/_WeldBootstrapBean state=Configured
java.lang.UnsupportedClassVersionError: Bad version number in .class file

[alesj]

Ales, can you please take a quick look at https://svn.jboss.org/repos/jbossas/projects/weld-int/trunk/deployer-mc-int/src/test/java/org/jboss/test/deployers/test/McIntegrationTestCase.java and see if there are some tests I have not thought of?

From the test method names it looks complete. :-)