Interceptor not getting called when pointcut is defined at i

[harivenkatrajan]

Hello,

I have this requirement where when a method is called
on EJB local interface some security code needs to get executed.
Hence I tried annotating the EJB local interface method and understood
that aopc does not instrument interface classes as I see this compilation
log.

[aopc] [cannot compile] isInterface: com.abc.HelloServiceLocal


I tried running a small example in eclipse with pointcut-interceptor
defined at interface level and do not see the interception happening
when invocation happens at interface level. I am not sure if I got
this concept itself wrong or if something else needs to be done to
get this working.

Pls, find the following files.

1. HelloAOP.java
2. HelloAOPInterceptor.java
3. HelloAOPInterface.java
4. jboss-aop.xml


1.
package com;
public class HelloAOP implements HelloAOPInterface{

public void callMe ()
{
System.out.println("AOP!");
}


public void secondCallMe ()
{
System.out.println("Second AOP!");
}


public static void main (String args[])
{

System.out.println("Calling through interface");
HelloAOPInterface helloI = new HelloAOP();
helloI.callMe();

System.out.println("Calling direct ");
HelloAOP hello = new HelloAOP();
hello.callMe();
hello.secondCallMe();
}
}


2.
package com;
import org.jboss.aop.advice.Interceptor;
import org.jboss.aop.joinpoint.Invocation;

public class HelloAOPInterceptor implements Interceptor {

public String getName() {
return "HelloAOPInterceptor";
}

//We renamed the arg0 parameter to invocation
public Object invoke(Invocation invocation) throws Throwable {
System.out.print("Hello, ");
//Here we invoke the next in the chain
return invocation.invokeNext();
}
}


3.
package com;
public interface HelloAOPInterface {
public void callMe ();
}


4.
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>










Here is output log :
Calling through interface
AOP!
Calling direct
AOP!
Hello, Second AOP!


Any suggestions will be appreciated.

[harivenkatrajan]

Here is the 4. Jboss-aop.xml

[harivenkatrajan]

Not sure why its not showing stripped out </>

aop
bind pointcut="execution(public void com.HelloAOPInterface-&gt;callMe())"

interceptor class="com.HelloAOPInterceptor"
bind
bind pointcut="execution(public void com.HelloAOP-&gt;secondCallMe())"
interceptor class="com.HelloAOPInterceptor"
bind
aop

[flavia.rainone]

The problem is in the pointcut expression. Execution pointcuts match only the body of the method, which is not present in HelloAOPInterface, given it is an interface. And, since you used the name "com.HelloAOPInterface" as the class that you intent to intercept, JBoss AOP restricts itself only to HelloAOPInterface, ignoring implementing classes.

To solve the issue, you should use $instanceof in your pointcut expression:

execution(public void $instanceof(com.HelloAOPInterface)->callMe())

This way, JBoss AOP will match all bodies of methods called "public void callMe()" contained in classes that implement HelloAOPInterface.

[harivenkatrajan]

I will try this suggestion. Appreciate it.