Prepare statement not picked up, am I missing something?

[rubenv]

I'm currently trying to get Dynamic AOP working in JBoss. Apparently, you need to prepare joinpoints. Here's what I'm using as source code:

Main.java:

package test;
import org.jboss.aop.AspectManager;
import org.jboss.aop.advice.AdviceBinding;
import org.jboss.aop.pointcut.ast.ParseException;

public class Main {
 public static void main(String[] args) throws ParseException {
 Main m = new Main();
 m.sayHello();

 AdviceBinding binding = new AdviceBinding("execution(* test.Main->sayHello())", null);
 binding.addInterceptor(TracingAspect.class);
 AspectManager.instance().addBinding(binding);

 m.sayHello();
 }

 private void sayHello() {
 System.out.println("Hello!");
 }
}

TracingAspect.java:

package test;
import org.jboss.aop.advice.Interceptor;
import org.jboss.aop.joinpoint.*;

public class TracingAspect implements Interceptor {
 @Override
 public String getName() {
 return "Hello tracing!";
 }

 @Override
 public Object invoke(Invocation invocation) throws Throwable {
 System.out.println("Traced hello: " + invocation);
 return invocation.invokeNext();
 }
}

jboss-aop.xml:

<?xml version="1.0" encoding="UTF-8"?>
<aop>
 <aspect class="test.TracingAspect"/>

 <prepare expr="execution(* test.Main->sayHello())" />
</aop>

I am running this with the following command line parameters:

-javaagent:lib/jboss-aop.jar=-hotSwap -ea -Djboss.aop.path=jboss-aop.xml

Yet still, for some reason, the TracingAspect is never invoked. When I add the following:

<bind pointcut="execution(* test.Main->sayHello())">
 <interceptor class="test.TracingAspect" />
</bind>

I can see the advice code being run, as expected (once for the first sayHello call, twice for the second one, because the interceptor has been added). This leads me to believe that the prepare isn't being noticed.

Anyone got a clue what I'm doing wrong?

[flavia.rainone]

rubenv wrote:
I can see the advice code being run, as expected (once for the first sayHello call, twice for the second one, because the interceptor has been added). This leads me to believe that the prepare isn't being noticed.

This is unexpected. It looks like you have found a bug.

Just to rule out any other possibilities, do you see the same behavior when you do AOP + AS in the standard way? I.e., when you add jboss-aop.xml (with the prepare statement) to the deploy directory before deploying your application, instead of setting a value for jboss.aop.path?

[rubenv]

Am not using AS at all (simply standalone JBoss AOP). I did however find out that dropping the -hotSwap parameter fixed the issue. Am not sure if that's how it should be, but it did the trick.

[flavia.rainone]

The JVM may take a while to perform the hot swap operation. Could you please add a Thread.sleep before the sayHello() call?

If it still not works, then it is a bug.