Log4JLogger doesn't print right source line

[robjellinghaus]

When I run the Seam 1.0.1GA Hibernate testexample, here's the very beginning of the "ant clean testexample" output:

testexample:
 [copy] Copying 44 files to C:\robj\dev\seam\jboss-seam\examples\hibernate\build\test
 [testng] INFO 03-07 10:40:37,125 (Log4JLogger.java:info:94) -reading components.xml
 [testng] INFO 03-07 10:40:37,218 (Log4JLogger.java:info:94) -reading properties from: /seam.properties

Note that all of the logging lines are "Log4JLogger.java:info:94". This is, of course, not what I want. I want to know where in the source is the original call to log.info, not the line number inside Log4JLogger!

This used to work with a previous beta of Seam, but broke somewhere along the way to 1.0.1GA. Anyone else noticed this? Troubled by it? Got a fix?????

Thanks :-)
Cheers,
Rob

[gavin.king]

Hmmmmm. I'm not quite sure what is going wrong there either....

[gavin.king]

OK, the problem is that stuff like %F, %L, %M don't work when using a logging wrapper like commons-logging or seam logging, since log4j inspects the stack frames to discover that stuff.

Anyway, we shouldn't be using that stuff, we should be using %c, so I changed the log4j.xml files in CVS.

[starksm64]

See the following issue which was fixed with a new commons logging patch.
http://jira.jboss.com/jira/browse/JBAS-3347

[gavin.king]

Scott, is there an easy adjustment I can make to Seam logging (a wrapper around commons-logging) to solve the problem there too?

[starksm64]

You have to use the "org.apache.commons.logging.impl.Log4JLogger" name as the callerFQCN in the calls to the log(String callerFQCN, Priority level, Object message, Throwable t) in order for the stack walking logic to find the caler.

http://fisheye.jboss.org/viewrep/~raw,r=1.2.2.1/JBoss/apache/commons-logging/src/java/org/apache/commons/logging/impl/Log4jProxy.java