Portal booking example loses conversation after validation e

[mauro.lopez]

In first place, I'm sorry I have done things in the wrong order: created a jira issue first (JBSEAM-344) and this topic second.

The issue details are:

Environment
JBoss 4.0.4.GA
JBoss Portal 2.4.0-Beta1
(used jems-installer-1.2.0.BETA)
JBoss Seam 1.0.1.GA

Description
Followed this steps:
- deployed the application in examples/portal using ant, as described in examples/portal/readme.txt
- Entered http://localhost:8080/portal
- Selected the SeamHibernate portlet tab, registered user, logged in...
- Searched hotels, selected one of them, and pressed the "Book" button.

In the Book Hotel screen, if the credit card number hasn't got 16 digits, a message is shown. After that, having entered 16 digits for the credit card, instead of the confirm screen, the "Search Hotels" screen is shown, with the message "No conversation".

So, after a failed validation, the conversation is lost.

In my own examples I've substituted conversational scope with session scope, just to see them working.


Now I've tested the same use case using the latest jems installer, which bundles JBoss Portal 2.4.0-GA, and I was able to exactly reproduce the problem.

may be I should try a previous version of JBoss Portal?

[mauro.lopez]

Full title should say Portal booking example loses conversation after validation error

Jira issue is http://jira.jboss.org/jira/browse/JBSEAM-344

[marlau]

I'm facing the same issue with these versions but I also tried: jbossAS 4.0.5.GA, jbossportal-2.6.0-DR1 and jbossSeam from cvs (yesterday) and this issue remains, that is, the conversation is lost.

I think that the problem is that the conversationId is not being written to the response when a validation fails. I see that in the class SeamPortletPhaseListener the conversationId is being written only if one of these conditions is true:

- event.getPhaseId() == INVOKE_APPLICATION
- facesContext.getResponseComplete()

When a validation fails, both of them are false every time that the method afterPhase is executed.

Any idea if this is going to be fixed in the next version?

Thanks in advance,
Laura

[gavin.king]

OK, this is certainly a bug. Is getRenderResponse() returning true, at least?

[marlau]

Yes, when a validation fails event.getFacesContext().getRenderResponse() is returning true in the afterPhase method executed after the phase PROCESS_VALIDATIONS.

[gavin.king]

Fixed in CVS, please test it for me, thanks.

[marlau]

It works. (tested with jboss-4.0.5.GA and jbossportal-2.6.0-DR1)
Thanks.

[gavin.king]

Excellent, thanks.