default equals() doesn't behave as expected for javaBean com

[matt.drees]

I'm not sure whether this is a bug or not, but it occupied a chunk of my time trying to debug this, and I thought others should be aware of it.

The javassist proxy for javaBeans components interferes with the default equals() method. After some interceptions, something like instance_javassist.equals(instance) is called, which fails, because they're different instances.

You can see this with something like this (which fails):

public class PingTest extends SeamTest {

 @Test
 public void test() throws Exception {
 new FacesRequest() {
 @Override
 protected void invokeApplication() {
 //call action methods here
 Ping ping = (Ping) getValue("#{ping}");
 Collection<Ping> pingSet = new ArrayList<Ping>();
 pingSet.add(ping);
 assert ping.equals(ping);
 }
 }.run();
 }
}

@Name("ping")
public class Ping {

 @Logger private Log log;

 @In FacesMessages facesMessages;

 public void ping()
 {
 log.info("ping.ping() action called");
 facesMessages.add("ping");
 }


}

If it's a bug, I'll file it in jira.

[matt.drees]

Oops, the collection stuff was leftovers from earlier when I had

assert pingSet.contains(ping);

which also fails.

[fhh]

The default equals method (of Object) checks if the objects are identical and returns false otherwise. So this behaviour is to be expected.

Overwrite equals() to get the behaviour you want.

Regards

Felix

[matt.drees]

It seems you shouldn't have to override equals() to get reflexive equality.

Like I said, maybe it's not a bug, but it sure as heck has the potential to cause confusion.

-Matt

[pmuir]

Matt, can you file an issue - I'm not sure if its something thats improvable on, but if there is an issue then hopefully Gavin can take a look when he's less busy :)

[matt.drees]

No problem.

http://jira.jboss.com/jira/browse/JBSEAM-1257

Thanks Pete.

[sammy8306]

Just a thought: wouldn't it be enough to let equals check the defined component name and scope for equality? That assumes that the name/scope pair is unique to the object and immutable, which holds as far as I can see?