EntityQuery by Extension wrong maxResults

[dajevtic]

Hello everyone,

I recently updated to the last CVS version of Seam and suddenly my EntityQuery objects always return one record less that I set using setMaxResults.
e.g. When I set max results to 5 per page, only 4 records are shown.
When hitting "Next" i am presented the records 6 through 9, etc.
The 5th record never gets shown.

Is this a known bug or do I have to change something in my Objects that extend EntityQuery?

Kind regards,
dj

[pampam]

There seams to be a bug in the query class.

truncResultList returns (maxResults-1) items at the moment

return results.subList(0, mr-1)

should be

return results.subList(0, mr)

Regards,
Robert

[dajevtic]

Excellent, thanks pampam!
Is it safe to change the code by myself or will this have any negative impact on any other parts of EntityQuery?

[dajevtic]

Wait! No good :-(
I am using CVS20070531 and the code alredy states:

protected List truncResultList(List results)
 {
 Integer mr = getMaxResults();
 if ( mr!=null && results.size() > mr )
 {
 return results.subList(0, mr);
 }
 else
 {
 return results;
 }
 }

Any idea what else could be causing the problem?

[dajevtic]

By the way I use .getDataModel() instead of .getResultList()
as the value binding for my dataTables.

[pampam]

sorry, I had not seen that it has already been corrected in cvs.

[gavin.king]

Are you *sure* you have the latest (fixed) CVS version??

I just tested this, and it works great...

[gavin.king]

Do you override createQuery()?

[dajevtic]

Hi Gavin. You were probable right. I used the cvs nightly build of 0531 which still had the problem. I am now using the current cvs (freshly checked out) and the results are shown correctly now.

I don't override createQuery however I do have a rather "uncommon" use of EntityQuery. I extend EntityQuery and the extended object is a stateful ejb3 session bean where I did override setEjbql() and some other "non-vital" functions (+ added a couple of my own "commonly" used functions).