Boiler-plate getMaxResults for domain object List class

[awhitford]

The boiler-plate for an entity List class overrides getMaxResults with a constant:

@Override
public Integer getMaxResults() {
 return 25;
}

Why is this done (or necessary)? The underlying Query (http://fisheye.jboss.com/browse/JBoss/jboss-seam/src/main/org/jboss/seam/framework/Query.java? r=1.32) class already has a property:

public Integer getMaxResults()
{
 return maxResults;
}

Users could set this variable in a constructor if they want to override the default 25.

I am surprised to see the getMaxResults return a constant because it means that the getter is inconsistent with the setter. For example, the following assertion fails:

myList.setMaxResults(50),
assert 50 == myList.getMaxResults();

It just doesn't seem right... And I don't see why I shouldn't be able to change the result set size.

Note that the EntityQuery class (or Query) should specify a default initialization for maxResults.

[gavin.king]

The generated code is just a starting point - you can change it to whatever you like (or even edit the template if it offends you that much).

In fact, it is *expected* 90% of the code that is generated is stuff that you would want to customize. If it was likely to not need customization, it would be in the framework, not in the boilerplate.

[awhitford]

I am afraid that you missed my point...

I am advocating that the framework (EntityQuery or Query) defines a default so that the numerous Entity List classes do not need to declare this.

[gavin.king]

I really don't want to pick some arbitrary default for a general purpose component that is used in other scenarios than list screens...