-
15. Re: <ui:insert /> stopped working in Seam 2.0 within source
rlubke Aug 9, 2007 4:02 PM (in response to mgrouch)Actually, it seems the regression was caused by a set of changes submitted by Gavin to Jacob.
https://facelets.dev.java.net/servlets/ReadMsg?list=cvs&msgNo=664
Unfortunately, the commit message doesn't offer much in the way of motivation behind these changes.
I've commented out lines 280 and 281 from DefaultFaceletContext and the test case that was posted to this thread then works.public boolean includeDefinition(UIComponent parent, String name) throws IOException, FaceletException, FacesException, ELException { boolean found = false; TemplateManager client; for (int i = 0; i < this.clients.size() && found == false; i++) { client = ((TemplateManager) this.clients.get(i)); if (client.equals(this.facelet)) continue; //if (client.isRoot() && i != 0) // break; found = client.apply(this, parent, name); } return found; }
Gavin - can you shed some light on what was being accomplished with these changes? -
16. Re: <ui:insert /> stopped working in Seam 2.0 within source
mgrouch Aug 22, 2007 10:12 PM (in response to mgrouch)Guys, is there a progress made on this? Source tags is a very important feature
which shouldn't be broken for 2.0... It seems the problem was localized to few lines of code already, just few more steps left to fix it...
Thanks -
17. Re: <ui:insert /> stopped working in Seam 2.0 within source
youngm Aug 30, 2007 11:13 AM (in response to mgrouch)I've recommitted the fix Ryan originally provided. Apparently the change that broke this was some functionality Jacob added for Gavin to support the s:decorate component. I tested the fix with the Seam s:decorate component in the Booking example's register page and the s:decorate appears to still correctly decorate the inputText fields on validation failure. If anyone who knows more about s:decorate can test the Facelets head further to ensure not breakages it would be appreciated.
Mike -
18. Re: <ui:insert /> stopped working in Seam 2.0 within source
mgrouch Sep 3, 2007 9:12 PM (in response to mgrouch)Mike, and other facelets developers,
When is a new facelets release can be expected?
Apart from this fix there are others which are long awaited
Ex: https://facelets.dev.java.net/servlets/ReadMsg?list=users&msgNo=8106
Thanks -
19. Re: <ui:insert /> stopped working in Seam 2.0 within source
pmuir Sep 4, 2007 4:34 AM (in response to mgrouch)FYI Mike and I discussed this end of last week, and he said he hoped there would be one soon once a couple more issues are resolved.
-
20. Re: <ui:insert /> stopped working in Seam 2.0 within source
mgrouch Sep 4, 2007 11:29 AM (in response to mgrouch)Great! Thanks