TimeZoneSelector discussion/enhancements

[mars1412]

I would suggest following enhancements to the TimeZoneSelector:

• 
  
• initialization:
  it is somewhat strange, that the getTimeZoneId() will return null, while a call to getTimeZone() will return the default timezone wouldn't it be better, to initialize the timezone Id to java.util.TimeZone.getDefault().getID() ?
  
• getTimeZones(): a function that can be used for selectItems
  same like the ThemeSelector.getThemes()
  I should return all available timezoneIDs (java.util.TimeZone.getAvailableIDs) sorted alphabetically
  --> here I am not really sure, if it is a good idea to return all of these timezones (there are really a lot of them on my system >500!)
  
  any comments appreciated

[pmuir]

Please create two jira issues, one for each feature request.

[mars1412]

created feature requests:

• TimeZoneSelector: Initialization
  http://jira.jboss.org/jira/browse/JBSEAM-2404
  
• TimeZoneSelector: getTimeZones()
  http://jira.jboss.org/jira/browse/JBSEAM-2405
  some additional comments on this one:
  
  • if java.util.TimeZone.getAvailableIDs() will be used, then please note,
    that 3digit timezones are deprecated:
    http://java.sun.com/j2se/1.5.0/docs/api/java/util/TimeZone.html
    
  • I am not sure, what is best to display as item description: maybe the timeZoneID or thejava.util.TimeZone.getDisplayName()
    
  • since there will be a lot of timezones, the list should be sorted alphabetically
    

[mars1412]

another comment on the second issue:
maybe that was already intendet to be implemented by timeZone/timeZoneSelector (http://jira.jboss.org/jira/browse/JBSEAM-405)