BeanMetaDataBuilder.createArray() surprise...

[dmlloyd]

BeanMetaDataBuilder.createArray() is defined to return a List. If you are naive like me, you'll pass in this value to e.g. BeanMetaDataBuilder.addConstructorParameter(). This method is overloaded. The BeanMetaDataBuilder.addConstructorParameter(Object) variant will pick it up and you'll end up with a deployment error.

The fix is to cast the List to ValueMetaData (because, lo and behold, the class which actually implements List is actually also a ValueMetaData as well) so that you get BeanMetaDataBuilder.addConstructorParameter(ValueMetaData) instead. This is a bit of a yucky API. How about adding an interface ArrayValueMetaData extends List, ValueMetaData and return that instead?

Just a thought after some very confused debugging on my part. :-)

[dmlloyd]

hm, well the forums ate the generics stuff but I hope you get the idea...

[alesj]

I'll think about it for 2.2.x. ;-)
It makes sense.

Probably for now, either
- you write you're own simple wrapping code
- we move some of the 'Object is instance of ValueMetaData' logic into right top places

But this is more of a dev discussion,
perhaps move it into MC dev forum. ;-)