-
1. Re: context name change
aguizar Jul 30, 2007 9:40 AM (in response to tom.baeyens)The new names for Context and Scope feel good. I'd even feel inclined to find an alternative for "Context" as it is a heavily overloaded class name, from the JNDI Context. What do you think of PvmContext?
Renaming ScopeRuntime to Scope collides with the definition class. If we rename that to ScopeDefinition, then we'd have to rename all BPEL activities to the likes of InvokeDefinition, ReceiveDefinition, etc. Not sure if I favor that, as there are many more definition than runtime classes. -
2. Re: context name change
tom.baeyens Jul 30, 2007 5:02 PM (in response to tom.baeyens)the clash with the bpel scope is indeed a problem. i'll see if my beauty sleep will shine a new light on the situation...
-
3. Re: context name change
tom.baeyens Jul 31, 2007 3:56 AM (in response to tom.baeyens)i completed the name change
Context --> Environment
Scope --> Context
i'm going to call the process runtime scope base class RuntimeProcessScope. It's not that conceise, but that is not a big problem since it is a class that only process language implementors will have to use. It's not part of the commonly used API. -
4. Re: context name change
tom.baeyens Jul 31, 2007 3:57 AM (in response to tom.baeyens)please keep an eye out for occurrences that i might have forgot to update.
-
5. Re: context name change
tom.baeyens Jul 31, 2007 4:00 AM (in response to tom.baeyens)next refactorings will probably be the following:
WireScope --> WireContext or ObjectFactory (not yet sure about that) i think ObjectFactory is the most applicable.
Also, I'll probably change Environment into an interface and work with a default implementation. -
6. Re: context name change
porcherg Aug 3, 2007 9:27 AM (in response to tom.baeyens)"tom.baeyens@jboss.com" wrote:
please keep an eye out for occurrences that i might have forgot to update.
In the WireParser, we have:defaultBindings.addBinding("scope", new ScopeBinding(), CATEGORY_DESCRIPTORS); defaultBindings.addBinding("environment", new ContextBinding(), CATEGORY_DESCRIPTORS); defaultBindings.addBinding("environment-factory", new ContextFactoryBinding(), CATEGORY_DESCRIPTORS);
Maybe we should rename:
"scope" -> "context"
ScopeBinding -> ContextBinding
ContextBinding -> EnvironmentBinding
ContextFactoryBinding -> EnvironmentFactoryBinding
What do you think about it ? -
7. Re: context name change
porcherg Aug 7, 2007 3:40 AM (in response to tom.baeyens)"tom.baeyens@jboss.com" wrote:
Context --> Environment
Scope --> Context
An environment would be composed of a number of contexts, like an application context, a block context (referring to the try-finally-block like in the code above), a transaction context, an execution context and so on.
In the Environment package, there are still many references to scopes. for example, in DefaultEnvironment, we define:public static final String SCOPENAME_APPLICATION = "application"; public static final String SCOPENAME_BLOCK = "block";
Are these fields referring to Context (and should be renamed) or are they referring to another scope concept ?
regards, Guillaume -
8. Re: context name change
tom.baeyens Aug 7, 2007 4:10 AM (in response to tom.baeyens)good point. i'll do a global search on scope and i should come accross most of those points.
that will probably have to wait till later this week since i'm doing concurrency now. -
9. Re: context name change
porcherg Aug 9, 2007 10:08 AM (in response to tom.baeyens)"porcherg" wrote:
In the WireParser, maybe we should rename:
"scope" -> "context"
ScopeBinding -> ContextBinding
ContextBinding -> EnvironmentBinding
ContextFactoryBinding -> EnvironmentFactoryBinding
I've just made these changes.
Guillaume