This content has been marked as final.
Show 3 replies
-
1. Re: javadoc feedback
porcherg Aug 14, 2007 3:39 AM (in response to tom.baeyens)"tom.baeyens@jboss.com" wrote:
check field transactionName in WireDefinition. not sure if this is feasible for you as it requires a lot of background information on what the transaction is for and how it's used. you if you want you can describe on this forum how you would move it to the environment.
I am not sure I understand what a transaction is.
Here is what I've understood from reading the code: In a wire context, we can specify a resource to be associated to a transaction, and then, when the context is being closed, the associated resources are committed or rolled back.
Is a transaction only associated with a block context or each context can define its own transaction ?
If only the block context has a transaction, we could move the transactionName to the EnvironmentFactory. During the parsing of the environment xml, we could modify StandardTransactionBinding to push the created TransactionDescriptor into the Parse. We can later get the descriptor of the Transaction from the parse to set a transactionName field in the environmentFactory (and then set it in the created environments).
Can this modification work ?
Guillaume -
2. Re: javadoc feedback
tom.baeyens Aug 14, 2007 4:02 AM (in response to tom.baeyens)"porcherg" wrote:
Is a transaction only associated with a block context or each context can define its own transaction ?
That is indeed the point. A transaction only makes sense on a block context."porcherg" wrote:
If only the block context has a transaction, we could move the transactionName to the EnvironmentFactory. During the parsing of the environment xml, we could modify StandardTransactionBinding to push the created TransactionDescriptor into the Parse. We can later get the descriptor of the Transaction from the parse to set a transactionName field in the environmentFactory (and then set it in the created environments).
Can this modification work ?
From the sound of it, that is what i want. You can go ahead and make this change.
I have ported test org.jbpm.msg.MemMessageServiceTest into pvm. That test is succeeding now. If that test succeeds after you made the change, check in and ping me here. -
3. Re: javadoc feedback
porcherg Aug 14, 2007 4:42 AM (in response to tom.baeyens)Pushing the StandardTransactionDescriptor in the Parse does not work because the WireParser pushes aWireDefinition, then pops the first element of the parse (WireDefinition before, the transaction descriptor with my first idea)
I don't think a modification in the WireParser is a good solution. I tried to have the same result by just searching for a StandardTransactionDescriptor in the block wireDefinition.
With this method, the test succeeds.
I've just submitted my modifications.
I have also removed the argument 'objectName' from the method 'processPendingInitialization' in WireContext (this argument was not used in the method)
Guillaume