This content has been marked as final.
Show 6 replies
-
1. Re: use generics in commands
aguizar Apr 3, 2008 4:55 AM (in response to porcherg)I was thinking about the same. In addition to the change you mention, we'd have to change the declaration of CommandService.execute() to something like:
public <T> T execute(Command<T> command)
Come to think of it, maybe only Command.execute() should be generic. I'm not quite sure the type parameter belongs to the entire class. It'd be interesting to evaluate both alternatives and see which one yields a cleaner interface. -
2. Re: use generics in commands
tom.baeyens Apr 3, 2008 8:42 AM (in response to porcherg)Great idea !
-
3. Re: use generics in commands
mvaldes Apr 3, 2008 8:52 AM (in response to porcherg)Good, with this update i'm ok on changing the current XPDL extension APIs to use commands.
So, we will take a look on changing our proxy-interceptors approach by commands. This will allow us to still exposing APIs to end users (based on commands) + use commands directly as extension points.
regards,
Miguel Valdes -
4. Re: use generics in commands
tom.baeyens Apr 3, 2008 9:17 AM (in response to porcherg)Awsome. Let me know if you need my help in making the command generics refactoring.
-
5. Re: use generics in commands
porcherg Apr 7, 2008 6:21 AM (in response to porcherg)I submitted the refactoring of Command interface to use generics.
I updated the Job and Message classes to use generics too (these classes implement Command).
regards,
Guillaume -
6. Re: use generics in commands
tom.baeyens Apr 7, 2008 6:22 AM (in response to porcherg)perfect! thanks.