some bugs with ActivityInstances

[porcherg]

I tried to use a pvm with activityInstances in Orchestra and I had some problems in ExecutionImpl:

- method createActivityInstanceScope: hasActivityInstances is set to true only if activityInstances == null. But with hibernate, when a collection is fetched from the database, it is never null, but it is an empty collection. As a result, hasActivityInstances is never set to true.

- method destroyActivityInstanceScope: if the list of activityInstances is empty, it is set to null. This creates an exception with hibernate.

- method destroyActivityInstanceScope: this methods modifies the node field of the execution, this breaks the value of previousNode. (previous node is used in bpel sequences)
Why is the execution node updated when an ActivityInstance is destroyed ?

regards,
Guillaume

[porcherg]

"porcherg" wrote:
method destroyActivityInstanceScope: this methods modifies the node field of the execution, this breaks the value of previousNode. (previous node is used in bpel sequences)

I added tests (NeedsPreviousTest.java) for the needPrevious feature. 2 tests fails (one of them because of the bug in desctoyActivityInstanceScope)

These tests are not included in the pvm test suite.

regards,
Guillaume

[tom.baeyens]

great. thanks.
i'll have a look asap.

[porcherg]

I submitted a patch for the "needs previous" bug (it just restores the original node before calling "moveTo").
I added the NeedsPreviousTest to the pvm test suite.

regards, Guillaume