JDBCStore and JDBCImple: connection leak?

[mauromol]

Hello!

We have another problem with JBossTS.

We set up the Object Store to use JDBC, so we provide our implementation of com.arjuna.ats.internal.arjuna.objectstore.jdbc.accessors.accessor that retrieves a connection to the DB used to save the Object Store data.

When the Object Store is initialized and com.arjuna.ats.internal.arjuna.objectstore.JDBCStore.setupStore(String, String) is called (on a JDBCActionStore object), I see that the connection obtained from the accessor is saved into a com.arjuna.ats.internal.arjuna.objectstore.JDBCImple instance within the method initialise(Connection, JDBCAccess, String). More precisely, it's saved in an array called _theConnection.

However, the connections in this array are never closed! There's just reconnect(int) that closes a connection before getting a new one.
When shutting down the whole JBossTS, one connection remains open inside the _theConnection array of JDBCImple and I find no way to do cleanup except by implementing this feature in our implementation of the accessor (that is: tracking down given connections and closing them all at shutdown).

Any hint to do this in a more clean way would be appreciated.

Thank you in advance!

Mauro.

[marklittle]

Can you not close them in your JDBCAccess implementation?

[mauromol]

Can you not close them in your JDBCAccess implementation?

This is what I am doing now... However there's no hint in accessor or JDBCAccess documentation that says that the connections used by the Object Store are never closed (except when reconnecting, to get another one). One could also think that putConnection is used by the object store when the connection is no longer used so that it can be closed by the accessor, but:
- the Object Store closes it by itself before calling putConnection
- in any case, putConnection is called only when reconnecting
- so one connection will always be kept and not returned... if JBossTS is shut down, that connection is leaked.

May I open a new JIRA?

Mauro.

[mauromol]

Can you not close them in your JDBCAccess implementation?

By the way: what I am doing is to register a "hook" in my webapp shutdown to close all the connection given away by my JDBCAccess implementation on webapp shutdown. So, all connections returned by getConnection() are tracked down by JDBCAccess in order to do such cleanup.

Mauro.

[marklittle]

Sounds reasonable. I've created a feature request issue. Not sure if/when we'll get to this because there may be backward compatibility issues, particularly when running embedded.

[mauromol]

Sounds reasonable. I've created a <a href="https://jira.jboss.org/jira/browse/JBTM-465">feature request</a> issue. Not sure if/when we'll get to this because there may be backward compatibility issues, particularly when running embedded.

Thank you Mark!

Mauro.