EJBTHREE-1978: No additional activationConfigProps for message-dest-link

[alrubinger]

@see https://jira.jboss.org/jira/browse/EJBTHREE-1978

Given:

<ejb-jar xmlns="http://java.sun.com/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
                  http://java.sun.com/xml/ns/javaee/ejb-jar_3_0.xsd"
  version="3.0">
  <!--
    TODO https://jira.jboss.org/jira/browse/EJBBOOK-6 Update the Schema
    to 3.1
  -->

  <enterprise-beans>

    <!--
      In this section we'll configure our MessageSendingEJB to use a
      message-destination-link
    -->
    <session>

      <!--
        This will match the value of @Stateless.name upon our bean
        implementation class
      -->
      <ejb-name>MessageSendingEJB</ejb-name>

      <!--
        Declare the Message Destination Reference which will be used in
        the bean implementation class as a logical reference to which
        we'll send messages
      -->
      <message-destination-ref>
        <message-destination-ref-name>jms/MessageDestinationLinkQueue</message-destination-ref-name>
        <message-destination-type>javax.jms.Queue</message-destination-type>
        <message-destination-usage>Produces</message-destination-usage>
        <message-destination-link>OurLinkName</message-destination-link>
      </message-destination-ref>
      <!-- Assume in jboss.xml we link this to a physical target mappedName -->

    </session>

    <!--
      Now we'll configure our MDB to receive messages from the logical
      name defined by the message-destination-link
    -->
    <message-driven>
      <ejb-name>MessageDestinationLinkMdb</ejb-name>
      <message-destination-link>OurLinkName</message-destination-link>
    </message-driven>

  </enterprise-beans>

  <!--
    Declare the Message Destination which is used as a logical name for
    linking
  -->
  <assembly-descriptor>
    <message-destination>
      <message-destination-name>OurLinkName</message-destination-name>
    </message-destination>
  </assembly-descriptor>

</ejb-jar>

...we've got enough metadata to associate the MDB with an underlying physical target (via the message-destination-link), so we shouldn't need activation config properties upon @MessageDriven.

The solution Jaikiran and I discussed was to resolve the link to the physical mapping during deployment, and set the metadata accordingly.

Open question: what do do in case of conflicts (ie. both logical name and activationConfigProps are specified but don't match?).  My suggestion to obey the activation config props and log a warning.

Full example in EJBBOOK-13.

S,

ALR

[jaikiran]

ALRubinger wrote:

Open question: what do do in case of conflicts (ie. both logical name and activationConfigProps are specified but don't match?).  My suggestion to obey the activation config props and log a warning.

IMO, it should be the other way around. XML overriding annotations. That will be consistent with how we handle other similar metadata.

[alrubinger]

jaikiran wrote:

IMO, it should be the other way around. XML overriding annotations. That will be consistent with how we handle other similar metadata.

Ah, good.  So we consider message destinations as equiv metadata to activation configuration, and overrides at the XML level apply.  I still think logging a warning is worth it; it's not very intuitive (because the metadata is not semantically equivalent).

S,

ALR

[jaikiran]

ALRubinger wrote:

I still think logging a warning is worth it; it's not very intuitive (because the metadata is not semantically equivalent).

I agree, a WARN message would be good.