proper examples cleanup?

[saltnlight5]

Hi,

In few of the jms examples I saw, they have this cleanup code in a finally block:

         if (initialContext != null)
         {
            initialContext.close();
         }
         if (connection != null)
         {
            connection.close();
         }

You probably should add another try/catch block to "initialContext.close();" because if it were to throw exception, you jms connection.close() will not be called.

-Z

[saltnlight5]

Hum... So was this too trival of a issue that no one wants to comment on?

I think a proper clean up of the resources in examples can go a long way for user to learn from.

If you want me to help update some of the examples, I will be happy to do that.

[timfox]

Zemian-

Feel free to open a JIRA on this one. And complete it if you like

[saltnlight5]

I will try to contribute patches when I have time later, but here is a jira issue:

https://jira.jboss.org/jira/browse/HORNETQ-307