ConnectionFactoryConfigurationImpl constructor

[clebert.suconic]

There is this constructor:

   public ConnectionFactoryConfigurationImpl(final String name,
                                             final List<Pair<TransportConfiguration, TransportConfiguration>> transportConfigs,
                                             final TransportConfiguration backupConfig,
                                             final String... bindings)
   {
      this(name, bindings);
      connectorConfigs = new ArrayList<Pair<TransportConfiguration, TransportConfiguration>>();
      connectorConfigs.addAll(transportConfigs);
   }
 

It seems a typo to me.

The parameter backupConfig wouldn't make sense here, it's actually not used.

[clebert.suconic]

I will remove the parameter.

I guess In theory I would have to deprecate the method and create a new one. (this could eventually break user's application when upgrading to the next release).

But I don't think it's a big deal on this case, so i will just remove it (unless anyone raise a concern).

[jmesnil]

yes, this parameter is an error for this constructor. All backup configs are passed in the transportConfigs List