JBoss 6.0.0M1 Handling of system properties (-P)

[bernd.koecke]

I used the -P parameter with JBoss 4.2.3 to set system properties. For example, to set 'jboss.bind.address' these lines are working:

run.sh -b10.0.0.2

run-sh -P<propfile with jboss.bind.address>

run.sh -Djboss.bind.address=10.0.0.2

export JAVA_OPTS="-Djboss.bind.address=10.0.0.2"; run.sh

But with JBossAS 6 only these two lines are possible:

run.sh -b10.0.0.2

export JAVA_OPTS="-Djboss.bind.address=10.0.0.2"; run.sh

I think I found the reason for this:

In 4.2.3 the 'org.jboss.Main' class has a 'props' field of type 'java.util.Properties' which uses the SystemProperties for defaults.

In 6.0.0 this field is a HashMap which gets a copy of all SystemProperties in the constructor. But only the handling of the -b parameter copies its value in the SystemProperties and in the 'props' field. The -D and -P parameter affect only the SystemProperties, but they don't affect the 'props' field. But the 'props' field is used for initialisation.

The result is, not all properties from the -P parameter are used by the server. Is this supposed to be like this?

Thanks a lot,

Bernd

[brian.stansberry]

Thanks for the report!

I had a look at the code in AS trunk[1] and it's a bit different from what you describe ('props' is no longer initialized from System.getProperties()). But it's still basically broken. I've opened https://jira.jboss.org/jira/browse/JBAS-7705

[1] http://anonsvn.jboss.org/repos/jbossas/trunk/main/src/main/java/org/jboss/Main.java

[bernd.koecke]

Thanks a lot for the answer! I used your link from the answer to jboss.org.Main in trunk and the constructor with JavaDoc 'Explicit constructor' does the copying I wanted to describe above. I may described it unclear, what I wanted to say is, that I think that the lines with comment 'Set default properties' is the problem. A rather easy fix could be, to copy the system properties after command line handling.

[brian.stansberry]

Ah, thanks for pointing out that constructor logic!

Yes, I agree that the thing to do is to copy the system properties after command line handling.

[bernd.koecke]

Should I give it a try and send a patch?