Missing AOP dependency?

[bob.mcwhirter]

Thanks to ALR for the 0.1.1 update today, jboss-reloaded-vdf-bootstrap-minimal seems to work against HEAD of AS versions of MC etc.

I had to add a dependency block to slurp in jboss-aop explicitly, though:

<dependency>
  <groupId>org.jboss.aop</groupId>
  <artifactId>jboss-aop</artifactId>
</dependency>

Otherwise, just starting the server would toss me some complaints in a no-op test that just starts and stops the server.

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.581 sec <<< FAILURE!
testNothing(org.torquebox.messaging.deployers.QueuesYamlParsingDeployerTest)  Time elapsed: 1.398 sec  <<< ERROR!
java.lang.Exception: Encountered exception in server startup
        at org.jboss.bootstrap.impl.mc.server.AbstractMCServerBase.bootstrapMcAndDescriptors(AbstractMCServerBase.java:325)
        at org.jboss.bootstrap.impl.mc.server.AbstractMCServerBase.doStart(AbstractMCServerBase.java:257)
        at org.jboss.bootstrap.impl.base.server.AbstractServer$StartServerTask.run(AbstractServer.java:413)
        at java.lang.Thread.run(Thread.java:637)
Caused by: java.lang.IllegalStateException: Incompletely deployed:

DEPLOYMENTS IN ERROR:
  Deployment "BeanMetaDataDeployer" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "JBossServer" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "ClassLoadingMetaDataParser" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "MainDeployer" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "JARStructureCandidates" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "JARStructure" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "DeclaredStructure" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "ClassLoaderClassPathDeployer" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "StructureBuilder" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "ClassLoaderSystem" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "BeanDeployer" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "JARFilter" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "ClassLoaderDescribeDeployer" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "ClassLoadingDefaultDeployer" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "ClassLoaderDeployer" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "FileStructure" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "ManagedDeploymentCreator" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "Deployers" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "StructuralDeployers" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "KernelDeploymentDeployer" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "ClassLoading" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder
  Deployment "ManagedObjectCreator" is in error due to: java.lang.NoClassDefFoundError: org/jboss/aop/ReflectiveAspectBinder

        at org.jboss.kernel.plugins.deployment.AbstractKernelDeployer.internalValidate(AbstractKernelDeployer.java:278)
        at org.jboss.kernel.plugins.deployment.AbstractKernelDeployer.validate(AbstractKernelDeployer.java:174)
        at org.jboss.bootstrap.impl.mc.server.AbstractMCServerBase.bootstrapMcAndDescriptors(AbstractMCServerBase.java:314)
        ... 3 more

Thanks,

Bob

[alrubinger]

Can I see your test?  If it was an issue with MC start/stop w/ VDF I'd have expected an error in the Reloaded bootstrap-vdf-minimal unit tests.

S,

ALR

[bob.mcwhirter]

The meat is in an abstract base test:

http://github.com/torquebox/torquebox/blob/vfs3/core/src/test/java/org/torquebox/AbstractDeployerTestCase.java

The actual unit test driving this is

http://github.com/torquebox/torquebox/blob/vfs3/core/src/test/java/org/torquebox/messaging/deployers/QueuesYamlParsingDeployerTest.java

Also, fwiw, start() only seems to guarantee moving the MCServer to STARTING not STARTED.  If you stop() too quickly, you get an error involving it being wrong to stop() something that isn't STARTED.

[alrubinger]

No need for the Thread.sleep; the server startup is going on in the main thread of execution.

server.start() will first put state to STARTING, then go through all bootstraps, then the postcondition upon return is state==STARTED.

S,

ALR

[alrubinger]

So the resolution was that if mc-aop-int is on the ClassPath, MC will require AOP to be present too.  Without it, no need for AOP.  Bob added it manually on his own and all was well.

S,

ALR