NullPointerException in HornetQActivation.setupSession

[wolfc]

In AS testsuite:

./build.sh -Dtest=ejb3/jbpapp3026 jbpp3026 test

At least no NPE should occur, but an informative exception.

11:38:07,872 ERROR [STDERR] java.lang.IllegalArgumentException: interface javax.resource.spi.endpoint.MessageEndpoint is not visible from class loader
11:38:07,873 ERROR [STDERR]     at java.lang.reflect.Proxy.getProxyClass(Proxy.java:353)
11:38:07,873 ERROR [STDERR]     at org.jboss.ejb3.mdb.inflow.JBossMessageEndpointFactory.createProxy(JBossMessageEndpointFactory.java:154)
11:38:07,873 ERROR [STDERR]     at org.jboss.ejb3.mdb.inflow.JBossMessageEndpointFactory.createEndpoint(JBossMessageEndpointFactory.java:142)
11:38:07,873 ERROR [STDERR]     at org.hornetq.ra.inflow.HornetQMessageHandler.setup(HornetQMessageHandler.java:171)
11:38:07,874 ERROR [STDERR]     at org.hornetq.ra.inflow.HornetQActivation.setup(HornetQActivation.java:286)
11:38:07,874 ERROR [STDERR]     at org.hornetq.ra.inflow.HornetQActivation$SetupActivation.run(HornetQActivation.java:496)
11:38:07,874 ERROR [STDERR]     at org.jboss.resource.work.WorkWrapper.run(WorkWrapper.java:172)
11:38:07,874 ERROR [STDERR]     at org.jboss.threads.SimpleDirectExecutor.execute(SimpleDirectExecutor.java:33)
11:38:07,874 ERROR [STDERR]     at org.jboss.threads.QueueExecutor.runTask(QueueExecutor.java:780)
11:38:07,874 ERROR [STDERR]     at org.jboss.threads.QueueExecutor.access$100(QueueExecutor.java:45)
11:38:07,875 ERROR [STDERR]     at org.jboss.threads.QueueExecutor$Worker.run(QueueExecutor.java:800)
11:38:07,875 ERROR [STDERR]     at java.lang.Thread.run(Thread.java:619)
11:38:07,875 ERROR [STDERR]     at org.jboss.threads.JBossThread.run(JBossThread.java:122)
11:38:07,875 ERROR [org.hornetq.ra.inflow.HornetQActivation] Unabler to start activation : java.lang.NullPointerException
    at org.hornetq.ra.inflow.HornetQActivation.setupSession(HornetQActivation.java:336)
    at org.hornetq.ra.inflow.HornetQActivation.setup(HornetQActivation.java:283)
    at org.hornetq.ra.inflow.HornetQActivation$SetupActivation.run(HornetQActivation.java:496)
    at org.jboss.resource.work.WorkWrapper.run(WorkWrapper.java:172)
    at org.jboss.threads.SimpleDirectExecutor.execute(SimpleDirectExecutor.java:33)
    at org.jboss.threads.QueueExecutor.runTask(QueueExecutor.java:780)
    at org.jboss.threads.QueueExecutor.access$100(QueueExecutor.java:45)
    at org.jboss.threads.QueueExecutor$Worker.run(QueueExecutor.java:800)
    at java.lang.Thread.run(Thread.java:619)
    at org.jboss.threads.JBossThread.run(JBossThread.java:122)

[clebert.suconic]

It seems an issue with EJB3.

I just tried the classLoader used by the Resource Adapter (through both this.getClass().getClassLoader() and ContextClassLoader), and that class is available.

JBoss AS has recently moved a few EE classes around. Maybe that affected you guys.

[clebert.suconic]

The class not found exception is indeed an EJB3 bug.

The JBossMessageEndpointFactory is creating a proxy here:

         Class proxyClass = java.lang.reflect.Proxy.getProxyClass(container.getBeanClass().getClassLoader(), interfaces);

that means the EJB MDB's classLoader.

which doesn't have access to the EE libraries.

If I changed it to be:

         Class proxyClass = java.lang.reflect.Proxy.getProxyClass(Thread.currentThread().getContextClassLoader(), interfaces);

It would work without a problem.

Now, another issue is the CreateDestinationsDeployer which is not being kicked by EJB3. There might be an issue with MC or dependencies here.

And finally, because the destinations wasn't created.. the ResourceAdapter got a null spec, and it didn't throw a proper error such as (spec wasn't initialized.. or some other proper message). We would need to change the ResourceAdapter to throw a proper error as Carlo said.

[clebert.suconic]

BTW: if this is not an EJB3 error, it will be something on the AS (about the MDB classloader not having access to the /common library).

[clebert.suconic]

One of the  NullPointerException might actually be a HornetQ issue (on the ResourceAdapter):

It seems like (I didn't inspect the code on EJB3) that Activation::setup and Activation::start are being called from different threads.

I could avoid a NPE if I applied the attached patch

The classLoader issue on EJB3 and the CreateDestinations are still EJB3 issues.

[clebert.suconic]

The NPE is a race of tearDown being caleld before setup was finished (because of the other issues, i.e. ClassLoader & CreateDestinationException).

I've tried a fix where the tearDown is also done through the Resourceworker, but I believe the ResourceWorker will enable multiple threads.. so the race was still there.

I've now committed the synchronize on tearDown and setup (r9017) and doing the teardown through the worker as well. @Andy.. if you could take a look please.

@Carlo (or EJB3 guys). I've already provided a patch on how to fix the ClassLoader issue. and the CreateDestination needs to be debugged. It will probably be an issue with MC. Let me know if you guys can debug that.

[clebert.suconic]

Do we actually need the setup being done in a different thread?

[ataylor]

Clebert Suconic wrote:

Do we actually need the setup being done in a different thread?

yes, this so it can be scheduled to be run after other services have been started.

[jaikiran]

Clebert Suconic wrote:

Now, another issue is the CreateDestinationsDeployer which is not being kicked by EJB3. There might be an issue with MC or dependencies here.

The create-destination feature has multiple issues https://jira.jboss.org/jira/browse/JBAS-7875

[ataylor]

jaikiran pai wrote:

Clebert Suconic wrote:

Now, another issue is the CreateDestinationsDeployer which is not being kicked by EJB3. There might be an issue with MC or dependencies here.

The create-destination feature has multiple issues https://jira.jboss.org/jira/browse/JBAS-7875

Is the classloader issue we are seeing a side effect of this or not?

[clebert.suconic]

Andy Taylor wrote:

jaikiran pai wrote:

Clebert Suconic wrote:

Now, another issue is the CreateDestinationsDeployer which is not being kicked by EJB3. There might be an issue with MC or dependencies here.

The create-destination feature has multiple issues https://jira.jboss.org/jira/browse/JBAS-7875

Is the classloader issue we are seeing a side effect of this or not?

It's either an issue with EJB3 or AS6 classloader

[clebert.suconic]

Andy Taylor wrote:

Clebert Suconic wrote:

Do we actually need the setup being done in a different thread?

yes, this so it can be scheduled to be run after other services have been started.

What that means? The Resource adapter is started before HornetQ?

[ataylor]

Clebert Suconic wrote:

Andy Taylor wrote:

Clebert Suconic wrote:

Do we actually need the setup being done in a different thread?

yes, this so it can be scheduled to be run after other services have been started.

What that means? The Resource adapter is started before HornetQ?

nope, it just means that they are all started once the server has fully started. its just how it works

[clebert.suconic]

I mean, if we don't use the Workerthread... we could do the setup before the server was started eventually?

Usually other services on JBoss will declare dependencies. I'm just trying to understand how this works.

[ataylor]

Clebert Suconic wrote:

I mean, if we don't use the Workerthread... we could do the setup before the server was started eventually?

Usually other services on JBoss will declare dependencies. I'm just trying to understand how this works.

I'm not sure what your first comment means.

If u create the sessions before the acyivation has fully started, messages may be delivered which would cause an error. This way messages only start getting delivered once the MDB has fully started.