Allow for configuring default resource adaptor name for the EJB2 MDBs

[aloubyansky]

https://jira.jboss.org/jira/browse/JBAS-7911

HornetQ team wants to be able to set the default resource adapter deployment name for all the proxy-factories configured in (standard)jboss.xml under invoker-proxy-bindings.

Currently, the default resource adapter name is hardcoded in http://anonsvn.jboss.org/repos/jbossas/trunk/server/src/main/java/org/jboss/ejb/plugins/inflow/JBossJMSMessageEndpointFactory.java

/** The JBoss resource adapter deployment name */
protected static String jmsra = "jms-ra.rar";

and can be overriden on the MDB level.

One option would be to add an element (e.g. resource-adapter-name) to proxy-factory-config to be able to set the default RA name on the proxy factory. The problem with this it will require changes in the DTD, i.e. a new version of the DTD will have to be added to the metadata project (we can't modify released DTD versions). It would be fine for JBoss-6.x but we'll have to make it work in JBoss-5.x as well (EAP).

Actually, AFAIU, HornetQ team wants to set the default RA name not only on the proxy-factory level but for all the proxy-factories.

If we consider adding another XML element then we'll get the same problem with the DTD described above.

I propose to initialize jmsra above from a system property with "jms-ra.rar" being the default in case the system property hasn't been set. This way we avoid the DTD issue.

[clebert.suconic]

I propose to initialize jmsra above from a system property with "jms-ra.rar" being the default in case the system property hasn't been set. This way we avoid the DTD issue.

And where that system property would be initialized?

You will end up having to add a XML somewhere anyway.. since it's not acceptable adding -D at run.sh.

So, I propose some MBean or something like it that will change the defalut name. (Or set the system property if you like).

We need to be able to configure what's the default name using

We just can't rely on the -D to define the behaviour of the resource adapters on this case.

[brian.stansberry]

Can there be a EAP versions of our DTDs, in this case and eap-5.1 version? I think this will be a recurring problem.

[clebert.suconic]

I was actually thinking.. .a System property would be good.. as long as it could be defined somewhere on the configs through some XML. As I said we will probably need some MBean that will define the system property?

If we had such property, we could have both EJB3 and EJB2 reading the same property.

[jaikiran]

Clebert Suconic wrote:

As I said we will probably need some MBean that will define the system property?

MBean won't be required. We can follow this syntax in the xmls:

${some.system.property.name:defaultvalue}

The xml parsing will look for a system property named "some.system.property.name" and if not already set, then will set the value to "defaultvalue"

[jason.greene]

Agreed. I don't see why we cant create an update dtd for EAP releases. The system property is a pretty ugly solution for this.

[aloubyansky]

IMO, a separate DTD for EAP is even uglier.

DTDs to be created are jboss_6_0.dtd, jboss_5_x_eap.dtd. And in case we want to support this in 5.x non-EAP versions then also jboss_5_x.dtd.

And after that, if we want to have a common setting for both EJB2 and EJB3 we may end-up with a system property anyway.

[clebert.suconic]

Right, and how do you set some.system.property.name without changing run.conf?

It is unacceptable to add a -D property to set this config. Whatever config we choose must be done through some XML that would be read at boot time.

A MC XML Bean setting a property would be fine since users are not meant to change it.

a System property is not.

[jaikiran]

Clebert Suconic wrote:

Right, and how do you set some.system.property.name without changing run.conf?

It is unacceptable to add a -D property to set this config.

I am not saying that we should be doing it through a system property.

[aloubyansky]

It's true that the best place to put this in is the same xml file where the factories are defined, i.e. (standard)jboss.xml. So, jboss_6_0.dtd makes sense.

I don't like the idea of a seperate DTD for EAP though. Putting it in some other xml file and getting it later from some managed bean (which would serve just this purpose) is not nicer. IMO, a system property would be better than that.

I can't suggest anything better. So, I guess I'm gonna do the DTDs.

I won't be able to complete this earlier than Monday though. Is that ok?

[jason.greene]

Alexey Loubyansky wrote:

IMO, a separate DTD for EAP is even uglier.

DTDs to be created are jboss_6_0.dtd, jboss_5_x_eap.dtd. And in case we want to support this in 5.x non-EAP versions then also jboss_5_x.dtd.

Yeah the forking can create a slight mess. One thing that does help though is that once an EAP line starts, we don't do community releases on that branch. So there should only be two descriptors. We could also call EAP 5.0, jboss 5.2, and EAP 5.1 jboss 5.3 etc if we want to keep them incremental.

[aloubyansky]

Which EAP version should this be supported in?

[aloubyansky]

Fixed. The default can now be set in  (standard)jboss.xml like this (this is the actual quote from the current standardjboss.xml)

<!DOCTYPE jboss PUBLIC
       "-//JBoss//DTD JBOSS 6.0//EN"
       "http://www.jboss.org/j2ee/dtd/jboss_6_0.dtd">
<jboss>
...
   <jms-resource-adapter>jms-ra.rar</jms-resource-adapter>
...