-
15. Re: Does the HornetQ RA work ok with non transacted
It's 9 pm in the UK now.
Why don't you have a go at fixing it?
-
16. Re: Does the HornetQ RA work ok with non transacted
Tim Fox wrote:
It's 9 pm in the UK now.
Why don't you have a go at fixing it?
I was going to do the release tomorrow after Andy committed his fix. (I wasn't expecting it to be fixed today)
This is already fixed on Andy's workspace. I just didn't have much information around it.
I will debug the same reported test again.
-
17. Re: Does the HornetQ RA work ok with non transacted
Sure np.
I just thought if it's a trivial fix, you could so it now to save some time.
If you think it's better to wait for Andy, no probs, you're probably in a better situation than me to know whether that's prudent.
-
18. Re: Does the HornetQ RA work ok with non transacted
@Tim: Just asking you a favour: don't know if you have any major commits planned for tomorrow. (I don't mind about minor fixes). maybe you could hold them until we finish this Beta2 release.
-
-
20. Re: Does the HornetQ RA work ok with non transacted
@Andy: From what I saw, the fix is just a one line change on where the ACK is called.
I have done all the tweaks on AS6 that will be needed to a new release. (Config changes... removing the transports jar.. etc).
I will finish the release on this Thursday (so I will also confirm with Andy about the change).
-
21. Re: Does the HornetQ RA work ok with non transacted
Its a simple fix, i just hadnt comitted yet since there was another issue around the same place with transaction timeouts.
Its a couple of lines i will commit this morning once i get to the office
-
22. Re: Does the HornetQ RA work ok with non transacted
Ok, this is commited. I have just run against the ejb3 test suite and only 2 tests fail, one to do with us not handling transaction timeouts correctly, https://jira.jboss.org/jira/browse/HORNETQ-363, which i have fixed locally but for some reason the test still fails. I will fix this today hopefully. The second failing MDB test is to do with DLQ which i havent looked at. The test may be invalid tho as HornetQ handles this differently.