3 Replies Latest reply on May 7, 2010 8:58 AM by bcarothers

    Errors in Subversion Connector docs

      I came across a few problems with the documentation for the subversion connector (http://docs.jboss.org/modeshape/latest/manuals/reference/html/subversion-connector.html).


      The link to SVNRepositorySource returns a 404.  The link is currently:

      http://docs.jboss.org/modeshape/1.1.0.Final/api/org/modeshape/connector/svn/SVNRepositorySource.html


      Changing it to:

      http://docs.jboss.org/modeshape/1.1.0.Final/api/org/modeshape/connector/svn/SvnRepositorySource.html

      takes you to the correct page


      In the programatic configuration example there are a couple problems.  I'm not sure if the first is a doc issue or a bug.  The following line does not work if the workspace is non-blank:

      .setProperty("repositoryRootUrl", "http://anonsvn.jboss.org/repos/modeshape");

      The code appends the workspace directly to this string, so this string should end in a slash:
      .setProperty("repositoryRootUrl", "http://anonsvn.jboss.org/repos/modeshape");

      Again, maybe that should be fixed in code rather than the doc.

      The second issue in the programatic config example is a simple typo; there is an endquote ('"') missing in the
      predefinedWorkspaceNames array definition.

      Finally, in the xml config example, the classname for the svn connector is incorrect.  It is listed as "
      org.modeshape.graph.connector.svn.SVNRepositorySource" but should be "org.modeshape.connector.svn.SvnRepositorySource"
      Additionally, the ending slash in the repo url is missing as with the programatic example given above.

      Kevin