Attribute names - problem in generated class

[blabno]

If we annotate getter getFor() with @Attribute annotation, then CDK will generate code like this:

protected static enum Properties {
        for
 }
public String getFor() {
        Object value = getStateHelper().eval(Properties.for);
        if(value == null) {
            return null;
        }
        return (String) value;
    }
    
    public void setFor(String for) {
        getStateHelper().put(Properties.for, for);
    }
 

Which doesn't compile, because "for" is a keyword. In _attribute_accessors.ftl template there is a code that checks if aliasFor is specified, however I can't see it set anywhere. Shouldn't first @Alias from @Attribute(alias=...) be used for that? If so then I attach appropriate patch.

[jbalunas]

Good catch, I'll have Alex take a look.  Could you create a jira for 4.0 and attach the patch?

Thanks

-Jay

[alexsmirnov]

Yes, that is a bug. I took a look for similar attribute in jsf-api and found that it uses 'forValue' as enum name while it returns "for" in toString method.

Seems that I have to check attributes for Java keyword and switch to similar solution if property name concurs with Java keyword.

I've created JIRA issue for that: https://jira.jboss.org/browse/RF-8898

[blabno]

Why adding "Value" suffix for java keywords only? Just add it to all property keys. Your solution is better then mine, because it doesn't involve and require user to know what's under the hood.