HHH-3766, HHH-5371, HHH-5499: Can I help?

[fbascheper]

Hi,

I'd very much like to see the following Envers issues fixed in the upcoming Hibernate 3.6 betas:

• HHH-3766 (and its duplicates, HHH-3709 and HHH-5372): if the end-revision column is available, it should be used in envers queries
• HHH-5371 (add a timestamp of the end-revision, to allow partioning of audit tables)
• HHH-5499 (extend AuditReader interface with findRevisions() method)

For each of these issues, a patch has already been suggested that fixes the issue. However, none of these patches have been implemented in the current trunk.

I'd really like to help with these issues, if at all possible. But I don't know where to start, because there are no comments on these patches, currently.

Of course, I could provide extra test-cases if necessary. Or I could update the patches with any suggestions you have to improve them, etc.

Thanks,

Erik-Berndt

[adamw]

Hello,

I really could use cloning .

Anyway, I added some comments to HHH-5372 (mainly cosmetical), applied HHH-5499 and also added comments to HHH-5371. If you could work on those patches it would be great. I'll also try to be more responsive, sorry for the delays

Adam

[fbascheper]

Hi,

That's great! Thanks for taking a look and resolving HHH-5499.

I have just submitted a revised patch for HHH-5372. I hope you like it even better than the original...

You will see that it took a fair bit more work than I originally anticipated.

Especially the delegation to the new methods in the AuditStrategy interface and the removal of duplicate code kept me busy ...

Kind regards,

Erik-Berndt

[fbascheper]

Hi,

Thanks for resolving HHH-5372!

I have just submitted two new patches for HHH-5371 (code and documentation).

Please take a look, and post your comments.

Regards,

Erik-Berndt