NetworkInterfaceBinding and wildcard addresses

[brian.stansberry]

There's a slight problem with NetworkInterfaceService. It has a single field for a NetworkInterface, but a wildcard address is associated with multiple network interfaces. So, some information may be lost.

[emuckenhuber]

Hmm, true. I think the main problem with this is the usage of NetworkInterfaceBinding with multicast addresses, since it uses the NetworkInterface. Maybe we just want to add a isWildcard() and return null for the network interface in this case?

[brian.stansberry]

Can NetworkInterfaceBinding return a Set<NetworkInterface> ?

Also, should SocketBinding.createMulticastSocket() be joining the group? Once it has created ManagedMulticastSocketBinding it has performed it's core mission of making sure the socket can be tracked. The caller can be responsible for other tasks, with SocketBinding just being responsible for provided all needed configuration information.

Somewhat related, I opened https://jira.jboss.org/browse/JBAS-8470 . We can deal with that after M1, if needed, as I don't think createMulticastSocket() is actually going to be used in M1.

[emuckenhuber]

Brian Stansberry wrote:

Can NetworkInterfaceBinding return a Set<NetworkInterface> ?

Sure.

Brian Stansberry wrote:

Also, should SocketBinding.createMulticastSocket() be joining the group? Once it has created ManagedMulticastSocketBinding it has performed it's core mission of making sure the socket can be tracked. The caller can be responsible for other tasks, with SocketBinding just being responsible for provided all needed configuration information.

Somewhat related, I opened https://jira.jboss.org/browse/JBAS-8470 . We can deal with that after M1, if needed, as I don't think createMulticastSocket() is actually going to be used in M1.

Yeah, maybe just creating ManagedMulticastSocketBinding would make more sense for now. We can review that as part of JBAS-8470 later again.