Working on HHH-4646 and HHH-5177

[hernanbolido]

Hi!

Here are HHH-4646 and HHH-5177.

I've been looking at these issues and I realized that the main  problem is the way we are reading the audited properties. In  AuditedPropertiesReader class we have:

private void addPropertiesFromClass(XClass clazz)  {
    XClass superclazz = clazz.getSuperclass();

    if (!clazz.isInterface() && !"java.lang.Object".equals(superclazz.getName())) {

        addPropertiesFromClass(superclazz);

    }

    addFromProperties(clazz.getDeclaredProperties("field"), "field", fieldAccessedPersistentProperties);
    addFromProperties(clazz.getDeclaredProperties("property"), "property", propertyAccessedPersistentProperties);
}

The actual algorithm process recursively superclasses. The concrete class is the last one processed.

I think we could fix this issue if we check concrete class  first and we process superclasses only if the concrete class has audited  properties (or is audited at class level).
Do you see any problem with these changes?

I've already developed a patch and I've run some tests (including both attached tests on 4646 and 5177).

After completing test cases I'll propose the patch if you agree.

Regars. Hernán

[hernanbolido]

Hi!

I've been working on this and I think I resolved this issues.

What is the new way to propose patches? Using gitHub push request?

Regards. Hernán.

[adamw]

Hello,

this looks good .

I think through pull requests, yes - please make one. I've never tried it before so it will interesting to see how it works.

Adam

[adamw]

I'm wondering which branch this should be on - I suppose both 3.6 and trunk (which will be 3.7 or 4)

Adam

[hernanbolido]

Well, I've send my firts pull request. Let's see how it works

If you have any questions, comments o corrections to make, let me know.

I hope it will help!

Regards. Hernán.

[hernanbolido]

One more thing...

I've only done it on 3.6 branch. If everything is ok, I can make another for master (ex-trunk)...

Hernán.

[adamw]

Great, it will be my first pull request merging . I'll try to do that tommorrow. And if all works well also merge to trunk

Adam

[fbascheper]

Adam,

Shouldn't this also go into the 3.5.x branch? 3.6.0 is so new we can't really expect everyone to migrate...

Kind regards,

Erik-Berndt