Feature request for maven aop plugin

[dpalmer]

Hi

I have been tasked with moving the JBoss ESB build from ant to maven; the current build relies the aopc ant task and the maven aop plugin doesn't seem to be flexible enough. I need to be able to configure which dependencies are included. So my feature request is for an iclude/excludes list for dependencies.

I think I should have the time to implement this in the scope of my current task but I'm sure you guys will have preferences as to how it is implemented. My thoughts are as follows:

1. The includes/excludes options will still require <includeProjectDependencies>true</includeProjectDependencies> and if no includes/excludes are set then all of the dependencies would be added to the classpath.

2. If there are any includes/excludes then a dependency would only be added if it appears in the includes list and it does not appear in the excludes list. Would it suffice to use the artifactId or should the comparison use the full coordinates?

3. Do you have a preference for the name of the elements? I'm leaning towards includedProjectDependencies and excludedProjectDependencies.

Regards

Doug

[stalep]

hi, just short answering the issues;

1. ok

2. i think the artifactid should be enough

3. the name you mentioned seems to describe it well enough in my head

i think its really nice that you take the time to do this. as i moved on to other projects i have not had the time/priority to update the maven plugin.

[dpalmer]

Here is a quick and dirty patch that implements this feature.

[stalep]

do you have access to svn? if so you can patch it and update the documentation regarding the plugin accordingly?

[dpalmer]

I guess this should also be applied to the AOP Mojo. There are no tests in the plugin source; is this plugin untested or do you have tests elsewhere.

Regards

Doug

[dpalmer]

I don't have access to your repository.

Regards

Doug

[stalep]

there are no tests to the plugin unfortunately.

kabir, what is the best way to do this? give douglas access or should i commit? im voting for giving him access

[kabirkhan]

You commit and verify this first patch.

The Douglas needs to send me his jboss.org username so I can add him

[dpalmer]

Here is a second patch that applies the change to both Mojos. If you want to give me commit access my id is [e-mail].

Regards

Doug

[kabirkhan]

I have added you